[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 00/15] virtio-gpu: split into two devices.
From: |
Kasireddy, Vivek |
Subject: |
RE: [PATCH 00/15] virtio-gpu: split into two devices. |
Date: |
Mon, 22 Mar 2021 18:41:47 +0000 |
Hi Gerd,
> On Fri, Mar 19, 2021 at 03:48:42PM +0400, Marc-André Lureau wrote:
> > Hi Gerd
> >
> > On Fri, Mar 19, 2021 at 3:22 PM Gerd Hoffmann <kraxel@redhat.com> wrote:
> >
> > > Currently we have one virtio-gpu device. Problem with this approach is
> > > that if you compile a full-featured qemu you'll get a virtio-gpu device
> > > which depends on opengl and virgl, so these dependencies must be
> > > installed and the libraries will be loaded into memory even if you don't
> > > use virgl. Also the code is cluttered with #ifdefs and a bit messy.
> > >
> > > This patch series splits the virtio-gpu device into two:
> > >
> > > (1) virtio-gpu-device becomes the non-virgl device, same as
> > > virtio-gpu-device,virgl=off today.
> > > (2) virtio-gpu-gl-device is the new virgl device, same as
> > > virtio-gpu-device,virgl=on today.
> > >
> > > When compiling qemu without virglrenderer support virtio-gpu-device
> > > behavior doesn't change.
[Kasireddy, Vivek] Just a random thought: if a user enables both these devices
either intentionally or accidentally, can they play nice with each other?
If this case is not allowed, where and how is that being enforced?
Thanks,
Vivek
> > >
> >
> > Nice!
> > We are post 6.0 soft freeze. I suppose you target those changes for 6.1?
>
> Yes, it's clearly 6.1 material at this point.
>
> take care,
> Gerd
- [PATCH 05/15] virtio-gpu: move virgl realize + properties, (continued)
- [PATCH 05/15] virtio-gpu: move virgl realize + properties, Gerd Hoffmann, 2021/03/19
- [PATCH 06/15] virtio-gpu: move virgl reset, Gerd Hoffmann, 2021/03/19
- [PATCH 08/15] virtio-gpu: move virgl handle_ctrl, Gerd Hoffmann, 2021/03/19
- [PATCH 13/15] virtio-gpu: move virtio-gpu-gl-device to separate module, Gerd Hoffmann, 2021/03/19
- [PATCH 15/15] virtio-gpu: move fields to struct VirtIOGPUGL, Gerd Hoffmann, 2021/03/19
- [PATCH 10/15] virtio-gpu: move virgl process_cmd, Gerd Hoffmann, 2021/03/19
- [PATCH 14/15] virtio-gpu: drop use_virgl_renderer, Gerd Hoffmann, 2021/03/19
- Re: [PATCH 00/15] virtio-gpu: split into two devices., no-reply, 2021/03/19
- Re: [PATCH 00/15] virtio-gpu: split into two devices., Marc-André Lureau, 2021/03/19