Re: [PATCH v5 07/57] tcg/tci: Split out tci_args_l

[Philippe Mathieu-Daudé]

On 3/11/21 3:39 PM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  tcg/tci.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/tcg/tci.c b/tcg/tci.c
> index bdd2127ec8..6e9d482885 100644
> --- a/tcg/tci.c
> +++ b/tcg/tci.c
> @@ -184,6 +184,11 @@ static tcg_target_ulong tci_read_label(const uint8_t 
> **tb_ptr)
>   *   s = signed ldst offset

Again, can you mention 'l -> label' here please?

>   */
>  
> +static void tci_args_l(const uint8_t **tb_ptr, void **l0)
> +{
> +    *l0 = (void *)tci_read_label(tb_ptr);
> +}

Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>