[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 10/10] qapi: New -compat deprecated-input=crash
From: |
Eric Blake |
Subject: |
Re: [PATCH v6 10/10] qapi: New -compat deprecated-input=crash |
Date: |
Mon, 15 Mar 2021 11:19:04 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/12/21 9:32 AM, Markus Armbruster wrote:
> Policy "crash" calls abort() when deprecated input is received.
>
> Bugs in integration tests may mask the error from policy "reject".
> Provide a larger hammer: crash outright. Masking that seems unlikely.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> qapi/compat.json | 9 +++++----
> qapi/qmp-dispatch.c | 1 +
> qapi/qobject-input-visitor.c | 1 +
> qemu-options.hx | 4 +++-
> 4 files changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/qapi/compat.json b/qapi/compat.json
> index d2c02a21aa..ae3afc22df 100644
> --- a/qapi/compat.json
> +++ b/qapi/compat.json
> @@ -11,11 +11,12 @@
> #
> # @accept: Accept silently
> # @reject: Reject with an error
> +# @crash: abort() the process
> #
> -# Since: 5.2
> +# Since: 6.0
Rebase churn once you fix this earlier in the series.
R-b still stands.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH v6 02/10] qapi: Implement deprecated-output=hide for QMP command results, (continued)
- [PATCH v6 02/10] qapi: Implement deprecated-output=hide for QMP command results, Markus Armbruster, 2021/03/12
- [PATCH v6 07/10] test-util-sockets: Add stub for monitor_set_cur(), Markus Armbruster, 2021/03/12
- [PATCH v6 05/10] monitor: Drop query-qmp-schema 'gen': false hack, Markus Armbruster, 2021/03/12
- [PATCH v6 10/10] qapi: New -compat deprecated-input=crash, Markus Armbruster, 2021/03/12
- Re: [PATCH v6 10/10] qapi: New -compat deprecated-input=crash,
Eric Blake <=
- [PATCH v6 06/10] qapi: Implement deprecated-output=hide for QMP introspection, Markus Armbruster, 2021/03/12
- [PATCH v6 09/10] qapi: Implement deprecated-input=reject for QMP command arguments, Markus Armbruster, 2021/03/12
- [PATCH v6 03/10] qapi: Implement deprecated-output=hide for QMP events, Markus Armbruster, 2021/03/12
- Re: [PATCH v6 00/10] Configurable policy for handling deprecated interfaces, Markus Armbruster, 2021/03/18