[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 07/10] test-util-sockets: Add stub for monitor_set_cur()
From: |
Eric Blake |
Subject: |
Re: [PATCH v6 07/10] test-util-sockets: Add stub for monitor_set_cur() |
Date: |
Mon, 15 Mar 2021 11:14:51 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/12/21 9:32 AM, Markus Armbruster wrote:
> Without this stub, the next commit fails to link. I suspect the real
> cause is 947e47448d "monitor: Use getter/setter functions for
> cur_mon".
>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/test-util-sockets.c | 1 +
> 1 file changed, 1 insertion(+)
We may be able to clean this up later, but in the interest of getting
this series into soft freeze,
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/tests/test-util-sockets.c b/tests/test-util-sockets.c
> index 67486055ed..72b9246529 100644
> --- a/tests/test-util-sockets.c
> +++ b/tests/test-util-sockets.c
> @@ -73,6 +73,7 @@ int monitor_get_fd(Monitor *mon, const char *fdname, Error
> **errp)
> * otherwise we get duplicate syms at link time.
> */
> Monitor *monitor_cur(void) { return cur_mon; }
> +Monitor *monitor_set_cur(Coroutine *co, Monitor *mon) { abort(); }
> int monitor_vprintf(Monitor *mon, const char *fmt, va_list ap) { abort(); }
>
> #ifndef _WIN32
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- Re: [PATCH v6 01/10] qemu-options: New -compat to set policy for deprecated interfaces, (continued)
- [PATCH v6 04/10] qapi: Implement deprecated-output=hide for QMP event data, Markus Armbruster, 2021/03/12
- [PATCH v6 08/10] qapi: Implement deprecated-input=reject for QMP commands, Markus Armbruster, 2021/03/12
- [PATCH v6 02/10] qapi: Implement deprecated-output=hide for QMP command results, Markus Armbruster, 2021/03/12
- [PATCH v6 07/10] test-util-sockets: Add stub for monitor_set_cur(), Markus Armbruster, 2021/03/12
- Re: [PATCH v6 07/10] test-util-sockets: Add stub for monitor_set_cur(),
Eric Blake <=
- [PATCH v6 05/10] monitor: Drop query-qmp-schema 'gen': false hack, Markus Armbruster, 2021/03/12
- [PATCH v6 10/10] qapi: New -compat deprecated-input=crash, Markus Armbruster, 2021/03/12
- [PATCH v6 06/10] qapi: Implement deprecated-output=hide for QMP introspection, Markus Armbruster, 2021/03/12
- [PATCH v6 09/10] qapi: Implement deprecated-input=reject for QMP command arguments, Markus Armbruster, 2021/03/12
- [PATCH v6 03/10] qapi: Implement deprecated-output=hide for QMP events, Markus Armbruster, 2021/03/12
- Re: [PATCH v6 00/10] Configurable policy for handling deprecated interfaces, Markus Armbruster, 2021/03/18