qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 08/10] qapi: Implement deprecated-input=reject for QMP com


From: Eric Blake
Subject: Re: [PATCH v6 08/10] qapi: Implement deprecated-input=reject for QMP commands
Date: Mon, 15 Mar 2021 11:16:30 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0

On 3/12/21 9:32 AM, Markus Armbruster wrote:
> This policy rejects deprecated input, and thus permits "testing the
> future".  Implement it for QMP commands: make deprecated ones fail.
> Example: when QEMU is run with -compat deprecated-input=reject, then
> 
>     {"execute": "query-cpus"}
> 
> fails like this
> 
>     {"error": {"class": "CommandNotFound", "desc": "Deprecated command 
> query-cpus disabled by policy"}}
> 
> When the deprecated command is removed, the error will change to
> 
>     {"error": {"class": "CommandNotFound", "desc": "The command query-cpus 
> has not been found"}}

Again, Dan's patch changes this permanently:
https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg07566.html

Up to you if you want to tweak the example, but the concept of the patch
is still fine, so my R-b still stands.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]