[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 08/10] qapi: Implement deprecated-input=reject for QMP com
From: |
Eric Blake |
Subject: |
Re: [PATCH v6 08/10] qapi: Implement deprecated-input=reject for QMP commands |
Date: |
Mon, 15 Mar 2021 11:16:30 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/12/21 9:32 AM, Markus Armbruster wrote:
> This policy rejects deprecated input, and thus permits "testing the
> future". Implement it for QMP commands: make deprecated ones fail.
> Example: when QEMU is run with -compat deprecated-input=reject, then
>
> {"execute": "query-cpus"}
>
> fails like this
>
> {"error": {"class": "CommandNotFound", "desc": "Deprecated command
> query-cpus disabled by policy"}}
>
> When the deprecated command is removed, the error will change to
>
> {"error": {"class": "CommandNotFound", "desc": "The command query-cpus
> has not been found"}}
Again, Dan's patch changes this permanently:
https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg07566.html
Up to you if you want to tweak the example, but the concept of the patch
is still fine, so my R-b still stands.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH v6 00/10] Configurable policy for handling deprecated interfaces, Markus Armbruster, 2021/03/12
- [PATCH v6 01/10] qemu-options: New -compat to set policy for deprecated interfaces, Markus Armbruster, 2021/03/12
- [PATCH v6 04/10] qapi: Implement deprecated-output=hide for QMP event data, Markus Armbruster, 2021/03/12
- [PATCH v6 08/10] qapi: Implement deprecated-input=reject for QMP commands, Markus Armbruster, 2021/03/12
- Re: [PATCH v6 08/10] qapi: Implement deprecated-input=reject for QMP commands,
Eric Blake <=
- [PATCH v6 02/10] qapi: Implement deprecated-output=hide for QMP command results, Markus Armbruster, 2021/03/12
- [PATCH v6 07/10] test-util-sockets: Add stub for monitor_set_cur(), Markus Armbruster, 2021/03/12
- [PATCH v6 05/10] monitor: Drop query-qmp-schema 'gen': false hack, Markus Armbruster, 2021/03/12
- [PATCH v6 10/10] qapi: New -compat deprecated-input=crash, Markus Armbruster, 2021/03/12