qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 01/13] net: Add ETH_ZLEN define in eth.h


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 01/13] net: Add ETH_ZLEN define in eth.h
Date: Mon, 15 Mar 2021 11:24:07 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0

On 3/15/21 11:15 AM, Bin Meng wrote:
> Hi Philippe,
> 
> On Mon, Mar 15, 2021 at 5:13 PM Philippe Mathieu-Daudé
> <philmd@redhat.com> wrote:
>>
>> On 3/15/21 8:57 AM, Bin Meng wrote:
>>> Add a new macro ETH_ZLEN which represents the minimum size of an
>>> Ethernet frame without FCS.
>>>
>>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>> ---
>>>
>>>  include/net/eth.h | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/include/net/eth.h b/include/net/eth.h
>>> index 0671be6916..7c825ecb2f 100644
>>> --- a/include/net/eth.h
>>> +++ b/include/net/eth.h
>>> @@ -31,6 +31,7 @@
>>>
>>>  #define ETH_ALEN 6
>>>  #define ETH_HLEN 14
>>> +#define ETH_ZLEN 60     /* Min. octets in frame sans FCS */
>>
>> What means 'sans'?
> 
> sans-serif font? Does that sound familiar? :)
> 
> Please check:
> https://www.dictionary.com/browse/sans

Ah this is a British expression from French...

I'd use "without" instead as it is probably clearer for
non-British and non-French developers.

> This comment was not invented by me, but was just a copy from the one
> used in Linux kernel:
> https://github.com/torvalds/linux/blob/d635a69dd4981cc51f90293f5f64268620ed1565/include/uapi/linux/if_ether.h#L35
> 
>>
>> Otherwise:
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>
> 
> Regards,
> Bin
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]