[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/13] net: Add a 'do_not_pad" to NetClientState
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 02/13] net: Add a 'do_not_pad" to NetClientState |
Date: |
Mon, 15 Mar 2021 10:18:13 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/15/21 10:17 AM, Philippe Mathieu-Daudé wrote:
> On 3/15/21 8:57 AM, Bin Meng wrote:
>> This adds a flag in NetClientState, so that a net client can tell
>> its peer that the packets do not need to be padded to the minimum
>> size of an Ethernet frame (60 bytes) before sending to it.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>> include/net/net.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/net/net.h b/include/net/net.h
>> index 919facaad2..6fab1f83f5 100644
>> --- a/include/net/net.h
>> +++ b/include/net/net.h
>> @@ -100,6 +100,7 @@ struct NetClientState {
>> int vring_enable;
>> int vnet_hdr_len;
>> bool is_netdev;
>> + bool do_not_pad;
>> QTAILQ_HEAD(, NetFilterState) filters;
>> };
>
> This is a bit pointless without the next patch, why
> not squash it there?
Ah one is SLiRP and the other is tap. OK then.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
[PATCH v2 04/13] net: tap: Pad short frames to minimum size before send, Bin Meng, 2021/03/15
[PATCH v2 03/13] net: slirp: Pad short frames to minimum size before send, Bin Meng, 2021/03/15
[PATCH v2 05/13] hw/net: virtio-net: Initialize nc->do_not_pad to true, Bin Meng, 2021/03/15
[PATCH v2 07/13] hw/net: vmxnet3: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/15
[PATCH v2 06/13] hw/net: e1000: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/15
[PATCH v2 08/13] hw/net: i82596: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/15