[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 20/23] tcg/tci: Use g_assert_not_reached
From: |
Richard Henderson |
Subject: |
[PATCH 20/23] tcg/tci: Use g_assert_not_reached |
Date: |
Wed, 27 Jan 2021 22:23:28 -1000 |
Three TODO instances are never happen cases.
Other uses of tcg_abort are also indicating unreachable cases.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/tci.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index 66b90f8489..2ce67a8fd3 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -360,7 +360,7 @@ static bool tci_compare32(uint32_t u0, uint32_t u1, TCGCond
condition)
result = (u0 > u1);
break;
default:
- TODO();
+ g_assert_not_reached();
}
return result;
}
@@ -402,7 +402,7 @@ static bool tci_compare64(uint64_t u0, uint64_t u1, TCGCond
condition)
result = (u0 > u1);
break;
default:
- TODO();
+ g_assert_not_reached();
}
return result;
}
@@ -1109,7 +1109,7 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState
*env,
tmp32 = qemu_ld_beul;
break;
default:
- tcg_abort();
+ g_assert_not_reached();
}
tci_write_reg(regs, t0, tmp32);
break;
@@ -1158,7 +1158,7 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState
*env,
tmp64 = qemu_ld_beq;
break;
default:
- tcg_abort();
+ g_assert_not_reached();
}
tci_write_reg(regs, t0, tmp64);
if (TCG_TARGET_REG_BITS == 32) {
@@ -1186,7 +1186,7 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState
*env,
qemu_st_bel(t0);
break;
default:
- tcg_abort();
+ g_assert_not_reached();
}
break;
case INDEX_op_qemu_st_i64:
@@ -1216,7 +1216,7 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState
*env,
qemu_st_beq(tmp64);
break;
default:
- tcg_abort();
+ g_assert_not_reached();
}
break;
case INDEX_op_mb:
@@ -1224,8 +1224,7 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState
*env,
smp_mb();
break;
default:
- TODO();
- break;
+ g_assert_not_reached();
}
tci_assert(tb_ptr == old_code_ptr + op_size);
}
--
2.25.1
- [PATCH 17/23] tcg/tci: Merge INDEX_op_st16_{i32,i64}, (continued)
- [PATCH 17/23] tcg/tci: Merge INDEX_op_st16_{i32,i64}, Richard Henderson, 2021/01/28
- [PATCH 18/23] tcg/tci: Move stack bounds check to compile-time, Richard Henderson, 2021/01/28
- [PATCH 21/23] tcg/tci: Remove dead code for TCG_TARGET_HAS_div2_*, Richard Henderson, 2021/01/28
- [PATCH 23/23] tcg/tci: Remove TODO as unused, Richard Henderson, 2021/01/28
- [PATCH 20/23] tcg/tci: Use g_assert_not_reached,
Richard Henderson <=
- [PATCH 19/23] tcg/tci: Merge INDEX_op_{st_i32,st32_i64}, Richard Henderson, 2021/01/28
- [PATCH 22/23] tcg/tci: Implement 64-bit division, Richard Henderson, 2021/01/28
- Re: [PATCH 00/23] TCI fixes and cleanups, Alex Bennée, 2021/01/28
- Re: [PATCH 00/23] TCI fixes and cleanups, Alex Bennée, 2021/01/28