[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 00/23] TCI fixes and cleanups
From: |
Alex Bennée |
Subject: |
Re: [PATCH 00/23] TCI fixes and cleanups |
Date: |
Thu, 28 Jan 2021 16:39:32 +0000 |
User-agent: |
mu4e 1.5.7; emacs 28.0.50 |
Richard Henderson <richard.henderson@linaro.org> writes:
> The first patch I believe is queued by Paolo, but is not yet
> upstream; copied here for convenience. Then, fill in all of
> the TODO blanks in TCI.
>
> The tci_write_reg* functions are redundant with tcg_write_reg.
> Just pass in the properly truncated result to begin. In the
> cases of the loads, we've automatically done that with the
> type of the indirection. For all of the other arithmetic,
> we don't actually have to do anything -- the value is either
> right, or the high bits are undefined. And in fact will
> currently be ignored by the extension on read.
Hmm it also failed CI pretty hard:
https://gitlab.com/stsquad/qemu/-/pipelines/248074046/failures
--
Alex Bennée
- [PATCH 20/23] tcg/tci: Use g_assert_not_reached, (continued)
- [PATCH 20/23] tcg/tci: Use g_assert_not_reached, Richard Henderson, 2021/01/28
- [PATCH 19/23] tcg/tci: Merge INDEX_op_{st_i32,st32_i64}, Richard Henderson, 2021/01/28
- [PATCH 22/23] tcg/tci: Implement 64-bit division, Richard Henderson, 2021/01/28
- Re: [PATCH 00/23] TCI fixes and cleanups, Alex Bennée, 2021/01/28
- Re: [PATCH 00/23] TCI fixes and cleanups,
Alex Bennée <=