Re: [PATCH v2 02/12] tests/meson: Only build softfloat objects if TCG is selected

[Claudio Fontana]

On 1/22/21 9:44 PM, Philippe Mathieu-Daudé wrote:
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Cc: Alex Bennée <alex.bennee@linaro.org>
> Cc: Emilio G. Cota <cota@braap.org>
> ---
>  tests/meson.build | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/meson.build b/tests/meson.build
> index 29ebaba48d2..6f1ff926d26 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -276,7 +276,9 @@
>       workdir: meson.current_source_dir() / 'decode',
>       suite: 'decodetree')
>  
> -subdir('fp')
> +if 'CONFIG_TCG' in config_all
> +  subdir('fp')
> +endif
>  
>  if not get_option('tcg').disabled()
>    if 'CONFIG_PLUGIN' in config_host
> 

Hi Philippe,

just looking at the context of this hunk,
is there a reason why we have different ways to say "tcg disabled",

ie CONFIG_TCG
and "get_option('tcg').disabled()"?

otherwise appears ok,
I am just thinking about what the next steps should be,
ie how to encompass everything tcg-related in a loadable module,

but it's still too early I guess to worry about that.

Thanks,

Claudio