[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/12] meson: Restrict block subsystem processing
From: |
Kevin Wolf |
Subject: |
Re: [PATCH v2 05/12] meson: Restrict block subsystem processing |
Date: |
Mon, 25 Jan 2021 13:15:29 +0100 |
Am 22.01.2021 um 21:44 hat Philippe Mathieu-Daudé geschrieben:
> Avoid generating module_block.h and block-gen.c if we are
> not going to use them.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: qemu-block@nongnu.org
> ---
> meson.build | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 61cbb89cd44..181f8795f5a 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1829,7 +1829,9 @@
>
> subdir('nbd')
> subdir('scsi')
> -subdir('block')
> +if have_block
> + subdir('block')
> +endif
>
> blockdev_ss.add(files(
> 'blockdev.c',
It feels odd to have a random have_block check in the middle of a whole
bunch of lines that all deal with block layer functionality, especially
when unconditional ones depend on the conditional one. (nbd, scsi and
blockdev.c present in the context here certainly all can't work without
block)
So should this if block become a bit longer and include all block layer
related things nearby?
If not, at least a comment explaining why we're doing this would be
nice.
Kevin
- [PATCH v2 00/12] buildsys: Do not build various objects if not necessary, Philippe Mathieu-Daudé, 2021/01/22
- [PATCH v2 01/12] configure: Only check for audio drivers if system-mode is selected, Philippe Mathieu-Daudé, 2021/01/22
- [PATCH v2 02/12] tests/meson: Only build softfloat objects if TCG is selected, Philippe Mathieu-Daudé, 2021/01/22
- [PATCH v2 03/12] pc-bios/meson: Only install EDK2 blob firmwares with system emulation, Philippe Mathieu-Daudé, 2021/01/22
- [PATCH v2 04/12] meson: Do not build optional libraries by default, Philippe Mathieu-Daudé, 2021/01/22
- [PATCH v2 05/12] meson: Restrict block subsystem processing, Philippe Mathieu-Daudé, 2021/01/22
- Re: [PATCH v2 05/12] meson: Restrict block subsystem processing,
Kevin Wolf <=
- [PATCH v2 06/12] meson: Merge trace_events_subdirs array, Philippe Mathieu-Daudé, 2021/01/22
- [PATCH v2 07/12] meson: Restrict some trace event directories to user/system emulation, Philippe Mathieu-Daudé, 2021/01/22
- [PATCH v2 08/12] meson: Restrict emulation code, Philippe Mathieu-Daudé, 2021/01/22
- [PATCH v2 09/12] qapi/meson: Restrict qdev code to system-mode emulation, Philippe Mathieu-Daudé, 2021/01/22