[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/8] tests/docker: Fix _get_so_libs() for docker-binfmt-image
From: |
Alex Bennée |
Subject: |
[PATCH v2 1/8] tests/docker: Fix _get_so_libs() for docker-binfmt-image |
Date: |
Fri, 22 Jan 2021 18:18:47 +0000 |
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Fix a variable rename mistake from commit 5e33f7fead5:
Traceback (most recent call last):
File "./tests/docker/docker.py", line 710, in <module>
sys.exit(main())
File "./tests/docker/docker.py", line 706, in main
return args.cmdobj.run(args, argv)
File "./tests/docker/docker.py", line 489, in run
_copy_binary_with_libs(args.include_executable,
File "./tests/docker/docker.py", line 149, in _copy_binary_with_libs
libs = _get_so_libs(src)
File "./tests/docker/docker.py", line 123, in _get_so_libs
libs.append(s.group(1))
NameError: name 's' is not defined
Fixes: 5e33f7fead5 ("tests/docker: better handle symlinked libs")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20210119050149.516910-1-f4bug@amsat.org>
---
tests/docker/docker.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/docker/docker.py b/tests/docker/docker.py
index 884dfeb29c..0b4f6167b3 100755
--- a/tests/docker/docker.py
+++ b/tests/docker/docker.py
@@ -120,7 +120,7 @@ def _get_so_libs(executable):
search = ldd_re.search(line)
if search:
try:
- libs.append(s.group(1))
+ libs.append(search.group(1))
except IndexError:
pass
except subprocess.CalledProcessError:
--
2.20.1
- [PATCH v2 0/8] testing/next (docker, binfmt, gdb version), Alex Bennée, 2021/01/22
- [PATCH v2 1/8] tests/docker: Fix _get_so_libs() for docker-binfmt-image,
Alex Bennée <=
- [PATCH v2 2/8] tests/docker: Fix typo in help message, Alex Bennée, 2021/01/22
- [PATCH v2 3/8] tests/docker: make _copy_with_mkdir accept missing files, Alex Bennée, 2021/01/22
- [PATCH v2 4/8] tests/docker: preserve original name when copying libs, Alex Bennée, 2021/01/22
- [PATCH v2 6/8] tests/docker: add a docker-exec-copy-test, Alex Bennée, 2021/01/22
- [PATCH v2 5/8] tests/docker: alias docker-help target for consistency, Alex Bennée, 2021/01/22
- [PATCH v2 7/8] configure: make version_ge more tolerant of shady version input, Alex Bennée, 2021/01/22
- [PATCH v2 8/8] configure: bump the minimum gdb version for check-tcg to 9.1, Alex Bennée, 2021/01/22
- Re: [PATCH v2 0/8] testing/next (docker, binfmt, gdb version), Alex Bennée, 2021/01/29