[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 7/8] configure: make version_ge more tolerant of shady version
From: |
Alex Bennée |
Subject: |
[PATCH v2 7/8] configure: make version_ge more tolerant of shady version input |
Date: |
Fri, 22 Jan 2021 18:18:53 +0000 |
When checking GDB versions we have to tolerate all sorts of random
distro extensions to the version string. While we already attempt to
do some of that before we call version_ge is makes sense to try and
regularise the first input by stripping extraneous -'s. While we at it
convert the old-style shell quoting into a cleaner form t shut up my
editors linter lest it confuse me by underlining the whole line.
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
configure | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 6f6a319c2f..dd99939b34 100755
--- a/configure
+++ b/configure
@@ -198,8 +198,8 @@ has() {
}
version_ge () {
- local_ver1=`echo $1 | tr . ' '`
- local_ver2=`echo $2 | tr . ' '`
+ local_ver1=$(expr "$1" : '\([0-9.]*\)' | tr . ' ')
+ local_ver2=$(echo "$2" | tr . ' ')
while true; do
set x $local_ver1
local_first=${2-0}
--
2.20.1
- [PATCH v2 0/8] testing/next (docker, binfmt, gdb version), Alex Bennée, 2021/01/22
- [PATCH v2 1/8] tests/docker: Fix _get_so_libs() for docker-binfmt-image, Alex Bennée, 2021/01/22
- [PATCH v2 2/8] tests/docker: Fix typo in help message, Alex Bennée, 2021/01/22
- [PATCH v2 3/8] tests/docker: make _copy_with_mkdir accept missing files, Alex Bennée, 2021/01/22
- [PATCH v2 4/8] tests/docker: preserve original name when copying libs, Alex Bennée, 2021/01/22
- [PATCH v2 6/8] tests/docker: add a docker-exec-copy-test, Alex Bennée, 2021/01/22
- [PATCH v2 5/8] tests/docker: alias docker-help target for consistency, Alex Bennée, 2021/01/22
- [PATCH v2 7/8] configure: make version_ge more tolerant of shady version input,
Alex Bennée <=
- [PATCH v2 8/8] configure: bump the minimum gdb version for check-tcg to 9.1, Alex Bennée, 2021/01/22
- Re: [PATCH v2 0/8] testing/next (docker, binfmt, gdb version), Alex Bennée, 2021/01/29