[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 03/10] iotests: Move try_remove to iotests.py
From: |
Max Reitz |
Subject: |
[PATCH v5 03/10] iotests: Move try_remove to iotests.py |
Date: |
Mon, 18 Jan 2021 11:57:13 +0100 |
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
---
tests/qemu-iotests/124 | 8 +-------
tests/qemu-iotests/iotests.py | 11 +++++++----
2 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/tests/qemu-iotests/124 b/tests/qemu-iotests/124
index 3705cbb6b3..e40eeb50b9 100755
--- a/tests/qemu-iotests/124
+++ b/tests/qemu-iotests/124
@@ -22,6 +22,7 @@
import os
import iotests
+from iotests import try_remove
def io_write_patterns(img, patterns):
@@ -29,13 +30,6 @@ def io_write_patterns(img, patterns):
iotests.qemu_io('-c', 'write -P%s %s %s' % pattern, img)
-def try_remove(img):
- try:
- os.remove(img)
- except OSError:
- pass
-
-
def transaction_action(action, **kwargs):
return {
'type': action,
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 52facb8e04..a69b4cdc4e 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -523,12 +523,15 @@ class FilePath:
return False
+def try_remove(img):
+ try:
+ os.remove(img)
+ except OSError:
+ pass
+
def file_path_remover():
for path in reversed(file_path_remover.paths):
- try:
- os.remove(path)
- except OSError:
- pass
+ try_remove(path)
def file_path(*names, base_dir=test_dir):
--
2.29.2
- [PATCH v5 00/10] iotests: Fix 129 and expand 297’s reach, Max Reitz, 2021/01/18
- [PATCH v5 03/10] iotests: Move try_remove to iotests.py,
Max Reitz <=
- [PATCH v5 01/10] iotests.py: Assume a couple of variables as given, Max Reitz, 2021/01/18
- [PATCH v5 04/10] iotests/129: Remove test images in tearDown(), Max Reitz, 2021/01/18
- [PATCH v5 05/10] iotests/129: Do not check @busy, Max Reitz, 2021/01/18
- [PATCH v5 06/10] iotests/129: Use throttle node, Max Reitz, 2021/01/18
- [PATCH v5 08/10] iotests/129: Limit mirror job's buffer size, Max Reitz, 2021/01/18
- [PATCH v5 07/10] iotests/129: Actually test a commit job, Max Reitz, 2021/01/18
- [PATCH v5 09/10] iotests/129: Clean up pylint and mypy complaints, Max Reitz, 2021/01/18
- [PATCH v5 10/10] iotests/300: Clean up pylint and mypy complaints, Max Reitz, 2021/01/18