[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 05/10] iotests/129: Do not check @busy
From: |
Max Reitz |
Subject: |
[PATCH v5 05/10] iotests/129: Do not check @busy |
Date: |
Mon, 18 Jan 2021 11:57:15 +0100 |
@busy is false when the job is paused, which happens all the time
because that is how jobs yield (e.g. for mirror at least since commit
565ac01f8d3).
Back when 129 was added (2015), perhaps there was no better way of
checking whether the job was still actually running. Now we have the
@status field (as of 58b295ba52c, i.e. 2018), which can give us exactly
that information.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
---
tests/qemu-iotests/129 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129
index 2fc65ada6a..dd23bb2e5a 100755
--- a/tests/qemu-iotests/129
+++ b/tests/qemu-iotests/129
@@ -69,7 +69,7 @@ class TestStopWithBlockJob(iotests.QMPTestCase):
result = self.vm.qmp("stop")
self.assert_qmp(result, 'return', {})
result = self.vm.qmp("query-block-jobs")
- self.assert_qmp(result, 'return[0]/busy', True)
+ self.assert_qmp(result, 'return[0]/status', 'running')
self.assert_qmp(result, 'return[0]/ready', False)
def test_drive_mirror(self):
--
2.29.2
- [PATCH v5 00/10] iotests: Fix 129 and expand 297’s reach, Max Reitz, 2021/01/18
- [PATCH v5 02/10] iotests/297: Rewrite in Python and extend reach, Max Reitz, 2021/01/18
- [PATCH v5 03/10] iotests: Move try_remove to iotests.py, Max Reitz, 2021/01/18
- [PATCH v5 01/10] iotests.py: Assume a couple of variables as given, Max Reitz, 2021/01/18
- [PATCH v5 04/10] iotests/129: Remove test images in tearDown(), Max Reitz, 2021/01/18
- [PATCH v5 05/10] iotests/129: Do not check @busy,
Max Reitz <=
- [PATCH v5 06/10] iotests/129: Use throttle node, Max Reitz, 2021/01/18
- [PATCH v5 08/10] iotests/129: Limit mirror job's buffer size, Max Reitz, 2021/01/18
- [PATCH v5 07/10] iotests/129: Actually test a commit job, Max Reitz, 2021/01/18
- [PATCH v5 09/10] iotests/129: Clean up pylint and mypy complaints, Max Reitz, 2021/01/18
- [PATCH v5 10/10] iotests/300: Clean up pylint and mypy complaints, Max Reitz, 2021/01/18