[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/18] target/arm: use arm_is_el2_enabled() where applicable
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 03/18] target/arm: use arm_is_el2_enabled() where applicable |
|
Date: |
Mon, 21 Dec 2020 12:54:08 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 12/18/20 2:37 AM, remi.denis.courmont@huawei.com wrote:
> From: Rémi Denis-Courmont <remi.denis.courmont@huawei.com>
>
> Do not assume that EL2 is available in non-secure context.
Just noticed this wording is off. Should be
"Do not assume that EL2 is unavailable in a secure context"
> That equivalence is broken by ARMv8.4-SEL2.
>
> Signed-off-by: Rémi Denis-Courmont <remi.denis.courmont@huawei.com>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/cpu.h | 4 ++--
> target/arm/helper-a64.c | 8 +-------
> target/arm/helper.c | 33 +++++++++++++--------------------
> 3 files changed, 16 insertions(+), 29 deletions(-)
- [PATCHv4 00/18] ARMv8.4-A Secure EL2, Rémi Denis-Courmont, 2020/12/18
- [PATCH 02/18] target/arm: add arm_is_el2_enabled() helper, remi . denis . courmont, 2020/12/18
- [PATCH 01/18] target/arm: remove redundant tests, remi . denis . courmont, 2020/12/18
- [PATCH 05/18] target/arm: factor MDCR_EL2 common handling, remi . denis . courmont, 2020/12/18
- [PATCH 03/18] target/arm: use arm_is_el2_enabled() where applicable, remi . denis . courmont, 2020/12/18
- Re: [PATCH 03/18] target/arm: use arm_is_el2_enabled() where applicable,
Richard Henderson <=
- [PATCH 06/18] target/arm: declare new AA64PFR0 bit-fields, remi . denis . courmont, 2020/12/18
- [PATCH 07/18] target/arm: add 64-bit S-EL2 to EL exception table, remi . denis . courmont, 2020/12/18
- [PATCH 04/18] target/arm: use arm_hcr_el2_eff() where applicable, remi . denis . courmont, 2020/12/18
- [PATCH 09/18] target/arm: add ARMv8.4-SEL2 system registers, remi . denis . courmont, 2020/12/18
- [PATCH 10/18] target/arm: handle VMID change in secure state, remi . denis . courmont, 2020/12/18
- [PATCH 08/18] target/arm: add MMU stage 1 for Secure EL2, remi . denis . courmont, 2020/12/18
- [PATCH 13/18] target/arm: generalize 2-stage page-walk condition, remi . denis . courmont, 2020/12/18
- [PATCH 15/18] target/arm: set HPFAR_EL2.NS on secure stage 2 faults, remi . denis . courmont, 2020/12/18
- [PATCH 11/18] target/arm: do S1_ptw_translate() before address space lookup, remi . denis . courmont, 2020/12/18
- [PATCH 12/18] target/arm: translate NS bit in page-walks, remi . denis . courmont, 2020/12/18