qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/3] target/nios2: Use deposit32() to update ipending regi


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 3/3] target/nios2: Use deposit32() to update ipending register
Date: Mon, 30 Nov 2020 10:55:07 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0

On 11/29/20 6:40 PM, Peter Maydell wrote:
> In nios2_cpu_set_irq(), use deposit32() rather than raw shift-and-mask
> operations to set the appropriate bit in the ipending register.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> In patch 1 I left the code for this identical to the old
> code from nios2_iic.c for clarity of that refactoring,
> but deposit32() is a clearer way to write it.
> ---
>  target/nios2/cpu.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]