[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 2/3] target/nios2: Move nios2_check_interrupts() into targ
From: |
Wu, Wentong |
Subject: |
RE: [PATCH v2 2/3] target/nios2: Move nios2_check_interrupts() into target/nios2 |
Date: |
Mon, 30 Nov 2020 05:43:00 +0000 |
On Monday, November 30, 2020 1:40 AM, Peter Maydell wrote:
> The function nios2_check_interrupts)() looks only at CPU-internal state; it
> belongs in target/nios2, not hw/nios2. Move it into the same file as its only
> caller, so it can just be local to that file.
>
> This removes the only remaining code from cpu_pic.c, so we can delete that
> file
> entirely.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/nios2/cpu.h | 2 --
> hw/nios2/cpu_pic.c | 36 ------------------------------------
> target/nios2/op_helper.c | 9 +++++++++
> hw/nios2/meson.build | 2 +-
> 4 files changed, 10 insertions(+), 39 deletions(-) delete mode 100644
> hw/nios2/cpu_pic.c
Reviewed and tested.
- [PATCH v2 0/3] target/nios2: Roll cpu_pic/nios2_iic code into CPU itself, Peter Maydell, 2020/11/29
- [PATCH v2 2/3] target/nios2: Move nios2_check_interrupts() into target/nios2, Peter Maydell, 2020/11/29
- RE: [PATCH v2 2/3] target/nios2: Move nios2_check_interrupts() into target/nios2,
Wu, Wentong <=
- [PATCH v2 3/3] target/nios2: Use deposit32() to update ipending register, Peter Maydell, 2020/11/29
- [PATCH v2 1/3] target/nios2: Move IIC code into CPU object proper, Peter Maydell, 2020/11/29
- Re: [PATCH v2 1/3] target/nios2: Move IIC code into CPU object proper, Philippe Mathieu-Daudé, 2020/11/30