[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.0 1/6] qapi: Add query-accel command
From: |
Eduardo Habkost |
Subject: |
Re: [PATCH for-6.0 1/6] qapi: Add query-accel command |
Date: |
Wed, 18 Nov 2020 11:23:19 -0500 |
On Wed, Nov 18, 2020 at 09:56:28AM -0600, Eric Blake wrote:
> On 11/18/20 9:45 AM, Eduardo Habkost wrote:
> > On Wed, Nov 18, 2020 at 02:53:26PM +0100, Markus Armbruster wrote:
> > [...]
> >> Another way to skin this cat:
> >>
> >> {"available": {"kvm": { extra properties... },
> >> "tcg": ...,
> >> "xen": ...},
> >> "active": "kvm"}
> >
> > How would this structure be represented in the QAPI schema?
> >
> > In other words, how do I say "Dict[str, AccelInfo]" in QAPIese?
>
> {'type':'AvailAccel', 'data': {
> '*kvm': 'KvmExtraProps',
> '*tcg': 'TcgExtraProps',
> '*xen': 'XenExtraProps',
> '*hax': 'HaxExtraProps' } }
> {'command':'query-accel', 'returns': {
> 'available': 'AvailAccel', 'active': 'strOrEnum' } }
>
> where adding a new accelerator then adds a new optional member to
> AvailAccel as well as possibly a new enum member if 'active' is driving
> by an enum instead of 'str'.
Is it possible to represent this if we don't enumerate all
possible dictionary keys in advance? (I'm not suggesting we
should/shouldn't do that, just wondering if it's possible)
--
Eduardo
- Re: [PATCH for-6.0 1/6] qapi: Add query-accel command, (continued)
- Re: [PATCH for-6.0 1/6] qapi: Add query-accel command, Roman Bolshakov, 2020/11/18
- Re: [PATCH for-6.0 1/6] qapi: Add query-accel command, Kevin Wolf, 2020/11/18
- Re: [PATCH for-6.0 1/6] qapi: Add query-accel command, Daniel P . Berrangé, 2020/11/18
- Re: [PATCH for-6.0 1/6] qapi: Add query-accel command, Markus Armbruster, 2020/11/18
- Re: [PATCH for-6.0 1/6] qapi: Add query-accel command, Eduardo Habkost, 2020/11/18
- Re: [PATCH for-6.0 1/6] qapi: Add query-accel command, Eric Blake, 2020/11/18
- Re: [PATCH for-6.0 1/6] qapi: Add query-accel command,
Eduardo Habkost <=
- Re: [PATCH for-6.0 1/6] qapi: Add query-accel command, Markus Armbruster, 2020/11/19
Re: [PATCH for-6.0 1/6] qapi: Add query-accel command, Philippe Mathieu-Daudé, 2020/11/30
[PATCH for-6.0 2/6] qapi: Rename KvmInfo to AccelInfo, Roman Bolshakov, 2020/11/16
[PATCH for-6.0 4/6] softmmu: Remove kvm_available(), Roman Bolshakov, 2020/11/16
[PATCH for-6.0 3/6] qapi: Use qmp_query_accel() in qmp_query_kvm(), Roman Bolshakov, 2020/11/16
[PATCH for-6.0 6/6] qapi: Deprecate 'query-kvm', Roman Bolshakov, 2020/11/16