Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

[Paolo Bonzini]

On 18/11/20 15:45, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
> > On 18/11/20 14:08, Markus Armbruster wrote:
> > > These look like errors, but aren't; things are working exactly as
> > > intended, and QEMU runs.  If we want to be chatty about it, we should
> > > make them info, not error.
> >
> > If there were an info_report, I would have sent a patch already. :)
>
> Commit 97f40301f1 "error: Functions to report warnings and informational
> messages", 2017-07-13 :)

Doh, I just learnt about info_report.  It never occurred to me until now 
that without a warning or info marker it would be an error.  I can see 
though why you didn't add "error" automatically for REPORT_TYPE_ERROR, 
while leaving REPORT_TYPE_INFO unadorned.  Between the 
incorrectly-marked errors and probably some "error: error: " it would be 
awful.

Paolo

> > In general, these are probably not the only cases where error_report
> > is used as a fancy fprintf(stderr), rather than to report actual
> > errors.
>
> True!