[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/9] plugins: Fix two resource leaks in setup_socket()
From: |
Alex Bennée |
Subject: |
[PULL 2/9] plugins: Fix two resource leaks in setup_socket() |
Date: |
Mon, 16 Nov 2020 12:24:10 +0000 |
From: Alex Chen <alex.chen@huawei.com>
Either accept() fails or exits normally, we need to close the fd.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20201109082829.87496-3-alex.chen@huawei.com>
Message-Id: <20201110192316.26397-3-alex.bennee@linaro.org>
diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index 319bd44b83..5aad50869d 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -268,11 +268,13 @@ static bool setup_socket(const char *path)
socket_fd = accept(fd, NULL, NULL);
if (socket_fd < 0 && errno != EINTR) {
perror("accept socket");
+ close(fd);
return false;
}
qemu_plugin_outs("setup_socket::ready\n");
+ close(fd);
return true;
}
--
2.20.1
- [PULL 0/9] various fixes (CI, Xen, warnings), Alex Bennée, 2020/11/16
- [PULL 1/9] plugins: Fix resource leak in connect_socket(), Alex Bennée, 2020/11/16
- [PULL 2/9] plugins: Fix two resource leaks in setup_socket(),
Alex Bennée <=
- [PULL 3/9] meson.build: fix building of Xen support for aarch64, Alex Bennée, 2020/11/16
- [PULL 4/9] include/hw/xen.h: drop superfluous struct, Alex Bennée, 2020/11/16
- [PULL 5/9] stubs/xen-hw-stub: drop xenstore_store_pv_console_info stub, Alex Bennée, 2020/11/16
- [PULL 6/9] accel/stubs: drop unused cpu.h include, Alex Bennée, 2020/11/16
- [PULL 8/9] tests/acceptance: Disable Spartan-3A DSP 1800A test, Alex Bennée, 2020/11/16
- [PULL 7/9] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off, Alex Bennée, 2020/11/16