[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/9] plugins: Fix resource leak in connect_socket()
From: |
Alex Bennée |
Subject: |
[PULL 1/9] plugins: Fix resource leak in connect_socket() |
Date: |
Mon, 16 Nov 2020 12:24:09 +0000 |
From: Alex Chen <alex.chen@huawei.com>
Close the fd when the connect() fails.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20201109082829.87496-2-alex.chen@huawei.com>
Message-Id: <20201110192316.26397-2-alex.bennee@linaro.org>
diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index a696673dff..319bd44b83 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -292,6 +292,7 @@ static bool connect_socket(const char *path)
if (connect(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)) < 0) {
perror("failed to connect");
+ close(fd);
return false;
}
--
2.20.1
- [PULL 0/9] various fixes (CI, Xen, warnings), Alex Bennée, 2020/11/16
- [PULL 1/9] plugins: Fix resource leak in connect_socket(),
Alex Bennée <=
- [PULL 2/9] plugins: Fix two resource leaks in setup_socket(), Alex Bennée, 2020/11/16
- [PULL 3/9] meson.build: fix building of Xen support for aarch64, Alex Bennée, 2020/11/16
- [PULL 4/9] include/hw/xen.h: drop superfluous struct, Alex Bennée, 2020/11/16
- [PULL 5/9] stubs/xen-hw-stub: drop xenstore_store_pv_console_info stub, Alex Bennée, 2020/11/16
- [PULL 6/9] accel/stubs: drop unused cpu.h include, Alex Bennée, 2020/11/16
- [PULL 8/9] tests/acceptance: Disable Spartan-3A DSP 1800A test, Alex Bennée, 2020/11/16
- [PULL 7/9] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off, Alex Bennée, 2020/11/16