[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] vhost-user-blk-server: depend on CONFIG_VHOST_USER

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 2/3] vhost-user-blk-server: depend on CONFIG_VHOST_USER
Date: Wed, 11 Nov 2020 10:25:22 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0

On 11/10/20 6:11 PM, Stefan Hajnoczi wrote:
> I interpreted CONFIG_VHOST_USER as controlling only QEMU's vhost-user
> device frontends. However, virtiofsd and contrib/ vhost-user device
> backends are also controlled by CONFIG_VHOST_USER. Make the
> vhost-user-blk server depend on CONFIG_VHOST_USER for consistency.

Possible follow up cleanup is to rename variable including

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> Now the following error is printed when the vhost-user-blk server is
> enabled without CONFIG_VHOST_USER:
>   $ ./configure --disable-vhost-user --enable-vhost-user-blk ...
>   ../meson.build:761:8: ERROR: Problem encountered: vhost_user_blk_server 
> requires vhost-user support
> Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Suggested-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  meson.build | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]