Re: [PATCH v3 07/11] gitlab-ci: Extract common job definition as 'cross_common_job'

[Philippe Mathieu-Daudé]

On 11/9/20 10:52 AM, Thomas Huth wrote:
> On 08/11/2020 23.19, Philippe Mathieu-Daudé wrote:
>> Extract the common definitions shared by '.cross_system_build_job'
>> and '.cross_user_build_job' to '.cross_common_job'.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  .gitlab-ci.d/crossbuilds.yml | 9 +++++----
>>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> 5 insertions, 4 deletions ... is it really that much better?

It becomes useful later we we add a lot into cross_common_job,
rather than duplicating in cross_[system/user]_build_job.

I understand this commit description lacks that information.

Thanks.