|
From: | Andrey Shinkevich |
Subject: | Re: [PATCH 0/2] Increase amount of data for monitor to read |
Date: | Mon, 9 Nov 2020 20:08:46 +0300 |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 |
On 09.11.2020 13:04, Vladimir Sementsov-Ogievskiy wrote:
09.11.2020 11:50, Vladimir Sementsov-Ogievskiy wrote:06.11.2020 15:42, Andrey Shinkevich wrote:The subject was discussed here: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg00206.html This series is a solution for the issue with QMP monitor buffered input. A little parser is introduced to throttle JSON commands read from the buffer so that QMP requests do not overwhelm the monitor input queue. A side effect raised in the test #247 was managed in the first patch. It may be considered as a workaround. Any sane fix suggested will be appreciated. Note: This series goes after the Vladimir's one: '[PATCH v3 00/25] backup performance: block_status + async"'To make the test #129 passed, the following patch should be applied first:'[PATCH v3 01/25] iotests: 129 don't check backup "busy"'.
[...]
Positive thing: the patches do increase performance: for me, the following command:(echo "{ 'execute': 'qmp_capabilities' }"; for i in {1..10000}; do echo "{ 'execute': 'query-block-jobs' }"; done; echo "{ 'execute': 'quit' }" ) | time ./qemu-system-x86_64 -qmp stdio > /dev/nullshows 2.4s on master and 0.6s after patches
Thank you for testing it. I'd like to include the result to the patch description with "Tested-by: ..."
Andrey
[Prev in Thread] | Current Thread | [Next in Thread] |