[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.2 3/4] qtest: escape device name in device-introspect-t
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH for-5.2 3/4] qtest: escape device name in device-introspect-test |
|
Date: |
Fri, 06 Nov 2020 16:34:37 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 06/11/20 14:15, Markus Armbruster wrote:
>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>
>>> device-introspect-test uses HMP, so it should escape the device name
>>> properly. Because of this, a few devices that had commas in their
>>> names were escaping testing.
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>
>> $ git-grep '\.name *= *"[^"]*,' | cat
>> hw/block/fdc.c: .name = "SUNW,fdtwo"
>> Any others?
>
> Not that I know, but this is a bug anyway. :)
Yes, but "a few devices" made me curious.
- Re: [PATCH for-5.2 4/4] qemu-option: warn for short-form boolean options, (continued)
[PATCH for-5.2 2/4] qemu-option: move help handling to get_opt_name_value, Paolo Bonzini, 2020/11/03
[PATCH for-5.2 3/4] qtest: escape device name in device-introspect-test, Paolo Bonzini, 2020/11/03
Re: [PATCH for-5.2 0/4] deprecate short-form boolean options, no-reply, 2020/11/03