[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/openrisc: fix icount handling for timer instructions
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH] target/openrisc: fix icount handling for timer instructions |
|
Date: |
Thu, 5 Nov 2020 13:39:35 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 11/5/20 3:54 AM, Pavel Dovgalyuk wrote:
> This patch adds icount handling to mfspr/mtspr instructions
> that may deal with hardware timers.
>
> Signed-off-by: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>
> ---
> target/openrisc/translate.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
Looks correct, but it would be better not to duplicate the code from
trans_l_mtspr, and use an is_jmp code (called DISAS_UPDATE_EXIT in some other
targets).
r~