[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp |
Date: |
Fri, 30 Oct 2020 11:12:18 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 29/10/20 14:38, Markus Armbruster wrote:
>> In my opinion, the Linux-specific abstract UNIX domain socket feature
>> introduced in 5.1 should have been rejected. The feature is niche,
>> the interface clumsy, the implementation buggy and incomplete, and the
>> test coverage insufficient. Review fail.
>>
>> Fixing the parts we can still fix now is regrettably expensive. If I
>> had the power to decide, I'd unceremoniously revert the feature,
>> compatibility to 5.1 be damned. But I don't, so here we go.
>>
>> I'm not sure this set of fixes is complete. However, I already spent
>> too much time on this, so out it goes. Lightly tested.
>>
>> Regardless, I *will* make time for ripping the feature out if we
>> decide to do that. Quick & easy way to avoid reviewing this series
>> *hint* *hint*.
>
> Apart from the nits pointed out in patch 7 (commit message) and 8 (code),
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Thanks, and don't forget to fix the hole that your head has left in the
> wall.
Thanks for the review, and thanks for cheering my up!
- Re: [PATCH 06/11] test-util-sockets: Test the complete abstract socket matrix, (continued)