[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/11] test-util-sockets: Test the complete abstract socket m
From: |
Eric Blake |
Subject: |
Re: [PATCH 06/11] test-util-sockets: Test the complete abstract socket matrix |
Date: |
Thu, 29 Oct 2020 14:19:15 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 10/29/20 8:38 AM, Markus Armbruster wrote:
> The test covers only two out of nine combinations. Test all nine.
> Four turn out to be broken. Marked /* BUG */.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/test-util-sockets.c | 86 ++++++++++++++++++++++++++++-----------
> 1 file changed, 63 insertions(+), 23 deletions(-)
>
> -static void test_socket_unix_abstract_good(void)
> +static void test_socket_unix_abstract(void)
> {
> - SocketAddress addr;
> + SocketAddress addr, addr_tight, addr_padded;
> + abstract_socket_matrix_row matrix[ABSTRACT_SOCKET_VARIANTS] = {
> + { &addr,
> + { &addr_tight, &addr_padded, &addr },
> + { false /* BUG */, true /* BUG */, true } },
> + { &addr_tight,
> + { &addr_padded, &addr, &addr_tight },
> + { false, false /* BUG */, true } },
> + { &addr_padded,
> + { &addr, &addr_tight, &addr_padded },
> + { true /* BUG */, false, true } }
> + };
> + int i;
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH 05/11] test-util-sockets: Synchronize properly, don't sleep(1), (continued)
- [PATCH 06/11] test-util-sockets: Test the complete abstract socket matrix, Markus Armbruster, 2020/10/29
- [PATCH 10/11] sockets: Bypass "replace empty @path" for abstract unix sockets, Markus Armbruster, 2020/10/29
- [PATCH 11/11] sockets: Make abstract UnixSocketAddress depend on CONFIG_LINUX, Markus Armbruster, 2020/10/29
- Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp, Marc-André Lureau, 2020/10/29