[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/11] test-util-sockets: Synchronize properly, don't sleep(1
From: |
Eric Blake |
Subject: |
Re: [PATCH 05/11] test-util-sockets: Synchronize properly, don't sleep(1) |
Date: |
Thu, 29 Oct 2020 13:54:51 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 10/29/20 8:38 AM, Markus Armbruster wrote:
> The abstract sockets test spawns a thread to listen and a accept, and
s/and a/and/
> a second one to connect, with a sleep(1) in between to "ensure" the
> former is listening when the latter tries to connect. Review fail.
> Risks spurious test failure, say when a heavily loaded machine doesn't
> schedule the first thread quickly enough. It's also slow.
>
> Listen and accept in the main thread, and start the connect thread in
> between. Look ma, no sleep! Run time drops from 2s wall clock to a
> few milliseconds.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/test-util-sockets.c | 39 +++++++++++++--------------------------
> 1 file changed, 13 insertions(+), 26 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH 08/11] sockets: Fix socket_sockaddr_to_address_unix() for abstract sockets, (continued)
- [PATCH 08/11] sockets: Fix socket_sockaddr_to_address_unix() for abstract sockets, Markus Armbruster, 2020/10/29
- [PATCH 02/11] test-util-sockets: Correct to set has_abstract, has_tight, Markus Armbruster, 2020/10/29
- [PATCH 01/11] test-util-sockets: Plug file descriptor leak, Markus Armbruster, 2020/10/29
- [PATCH 05/11] test-util-sockets: Synchronize properly, don't sleep(1), Markus Armbruster, 2020/10/29
- Re: [PATCH 05/11] test-util-sockets: Synchronize properly, don't sleep(1),
Eric Blake <=
- [PATCH 07/11] sockets: Fix default of UnixSocketAddress member @tight, Markus Armbruster, 2020/10/29
- Re: [PATCH 07/11] sockets: Fix default of UnixSocketAddress member @tight, Eric Blake, 2020/10/29
- [PATCH 06/11] test-util-sockets: Test the complete abstract socket matrix, Markus Armbruster, 2020/10/29