[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/9] target/sparc/win_helper: silence the compiler warnings
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 6/9] target/sparc/win_helper: silence the compiler warnings |
|
Date: |
Wed, 28 Oct 2020 10:51:23 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 10/28/20 5:18 AM, Chen Qun wrote:
> When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
> target/sparc/win_helper.c: In function ‘get_gregset’:
> target/sparc/win_helper.c:304:9: warning: this statement may fall through
> [-Wimplicit-fallthrough=]
> 304 | trace_win_helper_gregset_error(pstate);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> target/sparc/win_helper.c:306:5: note: here
> 306 | case 0:
> | ^~~~
>
> Add the corresponding "fall through" comment to fix it.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> ---
> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Cc: Artyom Tarasenko <atar4qemu@gmail.com>
> ---
> target/sparc/win_helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/sparc/win_helper.c b/target/sparc/win_helper.c
> index 8290a21142..32eacc05e6 100644
> --- a/target/sparc/win_helper.c
> +++ b/target/sparc/win_helper.c
> @@ -303,6 +303,7 @@ static inline uint64_t *get_gregset(CPUSPARCState *env,
> uint32_t pstate)
> default:
> trace_win_helper_gregset_error(pstate);
> /* pass through to normal set of global registers */
> + /* fall through */
Can you keep the comment, doing s/pass/fall/?
> case 0:
> return env->bgregs;
> case PS_AG:
>
[PATCH 6/9] target/sparc/win_helper: silence the compiler warnings, Chen Qun, 2020/10/28
[PATCH 5/9] target/sparc/translate: silence the compiler warnings, Chen Qun, 2020/10/28
[PATCH 9/9] hw/timer/renesas_tmr: silence the compiler warnings, Chen Qun, 2020/10/28
RE: [PATCH 9/9] hw/timer/renesas_tmr: silence the compiler warnings, Chenqun (kuhn), 2020/10/29