[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/9] target/sparc/translate: silence the compiler warnings
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 5/9] target/sparc/translate: silence the compiler warnings |
|
Date: |
Wed, 28 Oct 2020 10:50:34 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 10/28/20 5:18 AM, Chen Qun wrote:
> When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
> target/sparc/translate.c: In function ‘gen_st_asi’:
> target/sparc/translate.c:2320:12: warning: this statement may fall through
> [-Wimplicit-fallthrough=]
> 2320 | if (!(dc->def->features & CPU_FEATURE_HYPV)) {
> | ^
> target/sparc/translate.c:2329:5: note: here
> 2329 | case GET_ASI_DIRECT:
> | ^~~~
>
> The "fall through" statement place is not correctly identified by the
> compiler.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> ---
> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Cc: Artyom Tarasenko <atar4qemu@gmail.com>
> ---
> target/sparc/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/sparc/translate.c b/target/sparc/translate.c
> index 1a4efd4ed6..a3d9aaa46b 100644
> --- a/target/sparc/translate.c
> +++ b/target/sparc/translate.c
> @@ -2324,8 +2324,8 @@ static void gen_st_asi(DisasContext *dc, TCGv src, TCGv
> addr,
> }
> /* in OpenSPARC T1+ CPUs TWINX ASIs in store instructions
> * are ST_BLKINIT_ ASIs */
> - /* fall through */
> #endif
> + /* fall through */
> case GET_ASI_DIRECT:
> gen_address_mask(dc, addr);
> tcg_gen_qemu_st_tl(src, addr, da.mem_idx, da.memop);
>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- Re: [PATCH 1/9] target/i386: silence the compiler warnings in gen_shiftd_rm_T1, (continued)
Re: [PATCH 1/9] target/i386: silence the compiler warnings in gen_shiftd_rm_T1, Richard Henderson, 2020/10/28
[PATCH 6/9] target/sparc/win_helper: silence the compiler warnings, Chen Qun, 2020/10/28
[PATCH 5/9] target/sparc/translate: silence the compiler warnings, Chen Qun, 2020/10/28
[PATCH 9/9] hw/timer/renesas_tmr: silence the compiler warnings, Chen Qun, 2020/10/28
RE: [PATCH 9/9] hw/timer/renesas_tmr: silence the compiler warnings, Chenqun (kuhn), 2020/10/29
[PATCH 3/9] accel/tcg/user-exec: silence the compiler warnings, Chen Qun, 2020/10/28