[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 07/10] sabre: increase number of PCI bus IRQs from 32 to 64
From: |
Mark Cave-Ayland |
Subject: |
[PULL 07/10] sabre: increase number of PCI bus IRQs from 32 to 64 |
Date: |
Wed, 28 Oct 2020 08:23:55 +0000 |
The rework of the sabre IRQs in commit 6864fa3897 "sun4u: update PCI topology to
include simba PCI bridges" changed the IRQ routing so that both PCI and legacy
OBIO IRQs are routed through the sabre PCI host bridge to the CPU.
Unfortunately this commit failed to increase the number of PCI bus IRQs
accordingly meaning that access to the legacy IRQs OBIO (irqnum >= 0x20) would
overflow the PCI bus IRQ array causing strange failures running
qemu-system-sparc64
in NetBSD.
Cc: qemu-stable@nongnu.org
Reported-by: Harold Gutch <logix@foobar.franken.de>
Fixes: https://bugs.launchpad.net/qemu/+bug/1838658
Fixes: 6864fa3897 ("sun4u: update PCI topology to include simba PCI bridges")
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20201011081347.2146-1-mark.cave-ayland@ilande.co.uk>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
hw/pci-host/sabre.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c
index 5394ad5cd0..edf48ea923 100644
--- a/hw/pci-host/sabre.c
+++ b/hw/pci-host/sabre.c
@@ -388,7 +388,7 @@ static void sabre_realize(DeviceState *dev, Error **errp)
pci_sabre_set_irq, pci_sabre_map_irq, s,
&s->pci_mmio,
&s->pci_ioport,
- 0, 32, TYPE_PCI_BUS);
+ 0, 0x40, TYPE_PCI_BUS);
pci_create_simple(phb->bus, 0, TYPE_SABRE_PCI_DEVICE);
--
2.20.1
- [PULL 00/10] qemu-sparc queue 20201028, Mark Cave-Ayland, 2020/10/28
- [PULL 01/10] sparc32-dma: use object_initialize_child() for espdma and ledma child objects, Mark Cave-Ayland, 2020/10/28
- [PULL 02/10] sparc32-ledma: use object_initialize_child() for lance child object, Mark Cave-Ayland, 2020/10/28
- [PULL 03/10] sparc32-espdma: use object_initialize_child() for esp child object, Mark Cave-Ayland, 2020/10/28
- [PULL 04/10] sparc32-ledma: don't reference nd_table directly within the device, Mark Cave-Ayland, 2020/10/28
- [PULL 05/10] sabre: don't call sysbus_mmio_map() in sabre_realize(), Mark Cave-Ayland, 2020/10/28
- [PULL 06/10] hw/display/tcx: Allow 64-bit accesses to framebuffer stippler and blitter, Mark Cave-Ayland, 2020/10/28
- [PULL 07/10] sabre: increase number of PCI bus IRQs from 32 to 64,
Mark Cave-Ayland <=
- [PULL 08/10] hw/pci-host/sabre: Update documentation link, Mark Cave-Ayland, 2020/10/28
- [PULL 09/10] hw/pci-host/sabre: Remove superfluous address range check, Mark Cave-Ayland, 2020/10/28
- [PULL 10/10] hw/pci-host/sabre: Simplify code initializing variable once, Mark Cave-Ayland, 2020/10/28
- Re: [PULL 00/10] qemu-sparc queue 20201028, Peter Maydell, 2020/10/31