[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/3] unbreak non-tcg builds
From: |
Claudio Fontana |
Subject: |
Re: [PATCH v3 0/3] unbreak non-tcg builds |
Date: |
Mon, 26 Oct 2020 16:28:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
On 10/13/20 4:55 PM, Philippe Mathieu-Daudé wrote:
> On 10/13/20 4:38 PM, Claudio Fontana wrote:
>> This series now unbreaks current non-tcg builds
>> (!CONFIG_TCG).
>>
>> tests Makefiles need to avoid relying on all non-native
>> archs binaries to be present,
>>
>> bios-tables-test needs to skip tests that are tcg-only,
>>
>> and notably the replay framework needs to consider that
>> it might not be functional (or its code present at all)
>> without TCG.
>>
>> Tested ok target x86_64-softmmu on x86_64 host with:
>>
>> ./configure --enable-tcg --disable-kvm
>> ./configure --enable-kvm --disable-tcg
>> ./configure --enable-tcg --enable-kvm
>
> If you want to avoid these configurations to bitrot,
> consider covering them by adding Gitlab jobs :)))
>
>
Hi Philippe and all,
latest master now has all the fixes discussed in these series, thanks also to
Paolo's help with sorting out the stubs.
Already there is a new breakage though it seems, this time in qmp-cmd-test.
So adding CI coverage seems necessary.
In the .gitlab-ci.yml I see:
build-tcg-disabled:
[...]
- ../configure --disable-tcg --audio-drv-list="" || { cat config.log
meson-logs/meson-log.txt && exit 1; }
So is this supposed to be covered already?
I am confused also by the fact that it seems that suddently I see much "less"
stuff in the gitlab CI, did I miss some infra discussion?
Thanks,
Claudio
- [PATCH v3 1/3] tests/Makefile.include: unbreak non-tcg builds, (continued)
Re: [PATCH v3 0/3] unbreak non-tcg builds, Philippe Mathieu-Daudé, 2020/10/13