[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to t
From: |
Ani Sinha |
Subject: |
Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug |
Date: |
Wed, 30 Sep 2020 21:15:48 +0530 |
On Wed, Sep 30, 2020 at 8:59 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Wed, Sep 30, 2020 at 03:00:56PM +0530, Ani Sinha wrote:
> >
> > > > > Please let's not wait another week or so.
> >
> > > >
> >
> > > >
> >
> > > >
> >
> > > >
> >
> > > >
> >
> > > > OK it's not too much work but ... could you please add
> > justification
> >
> > > >
> >
> > > > about why adding this one unit test is needed so urgently?
> >
> > > >
> >
> > > > That motivation would be quite helpful for the pull request.
> >
> > > >
> >
> > > >
> >
> > > > A patch without unit test doesn't complete the patch work. A unit
> > test
> > makes
> >
> > > > sure that the change would not get broken by other changes that
> > come in
> > later.
> >
> > > > Typically all code changes are accompanied by unit test in the same
> > patch.
> >
> > > > Hence since the main work has already been merged, the unit test
> > should
> > merge
> >
> > > > ASAP so that no breakage can happen in between.
> >
> > > >
> >
> > > > Plus this completes an entire series of work which I've been working
> > for a
> >
> > > > while. I really would love to see it all merged cleanly and fully
> > completed.
> >
> > > >
> >
> > >
> >
> > > Absolutely, thanks for the great work!
> >
> > > I am not sure that's a good justification to rushing a pull request
> >
> > > though ... are you waiting to get paid and it hinges on the test, or
> > are
> >
> > > under a deadline, or something like this? It's okay to say so if so.
> >
> >
> >
> > Yes I am under a deadline too. Unfortunately can't disclose more
> > details.
> >
> >
> > Thanks Michael. Very much appreciate your help here.
> >
>
> OK Peter merged this. Hope this helps.
> Let's not make this a pattern please.
No this is a one time thing. Thanks to you and Peter for making an exception.
>
> --
> MST
>
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, (continued)
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Michael S. Tsirkin, 2020/09/29
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Ani Sinha, 2020/09/29
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Michael S. Tsirkin, 2020/09/30
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Ani Sinha, 2020/09/30
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Michael S. Tsirkin, 2020/09/30
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Ani Sinha, 2020/09/30
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Michael S. Tsirkin, 2020/09/30
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Ani Sinha, 2020/09/30
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Ani Sinha, 2020/09/30
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Michael S. Tsirkin, 2020/09/30
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug,
Ani Sinha <=
Re: [PATCH v10 00/13] i440fx/acpi: addition of feature and bug fixes., Philippe Mathieu-Daudé, 2020/09/18