[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to t
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug |
|
Date: |
Wed, 30 Sep 2020 04:04:33 -0400 |
On Wed, Sep 30, 2020 at 01:17:53PM +0530, Ani Sinha wrote:
>
>
> On Wed, Sep 30, 2020 at 1:14 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Wed, Sep 30, 2020 at 01:09:09PM +0530, Ani Sinha wrote:
>
> >
>
> >
>
> > On Wed, Sep 30, 2020 at 1:06 PM Michael S. Tsirkin <mst@redhat.com>
> wrote:
>
> >
>
> >Â Â Â On Tue, Sep 29, 2020 at 06:03:00PM +0530, Ani Sinha wrote:
>
> >
>
> >Â Â Â > On Tue, Sep 29, 2020 at 5:05 PM Michael S. Tsirkin
> <mst@redhat.com>
>
> >Â Â Â wrote:
>
> >
>
> >Â Â Â > >
>
> >
>
> >Â Â Â > > On Tue, Sep 29, 2020 at 04:58:03PM +0530, Ani Sinha wrote:
>
> >
>
> >Â Â Â > > > On Tue, Sep 29, 2020 at 4:45 PM Michael S. Tsirkin <
> mst@redhat.com>
>
> >Â Â Â wrote:
>
> >
>
> >Â Â Â > > > >
>
> >
>
> >Â Â Â > > > > On Tue, Sep 29, 2020 at 04:35:50PM +0530, Ani Sinha
> wrote:
>
> >
>
> >Â Â Â > > > > > On Tue, Sep 29, 2020 at 4:25 PM Michael S. Tsirkin <
>
> >Â Â Â mst@redhat.com> wrote:
>
> >
>
> >Â Â Â > > > > > >
>
> >
>
> >Â Â Â > > > > > > On Tue, Sep 29, 2020 at 04:11:45PM +0530, Ani Sinha
> wrote:
>
> >
>
> >Â Â Â > > > > > > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin
> <
>
> >Â Â Â mst@redhat.com> wrote:
>
> >
>
> >Â Â Â > > > > > > > >
>
> >
>
> >Â Â Â > > > > > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani
> Sinha
> wrote:
>
> >
>
> >Â Â Â > > > > > > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <
>
> >Â Â Â ani@anisinha.ca> wrote:
>
> >
>
> >Â Â Â > > > > > > > > > >
>
> >
>
> >Â Â Â > > > > > > > > > > In your pull request the following patch is
> completely
>
> >Â Â Â screwed up:
>
> >
>
> >Â Â Â > > > > > > > > > >
>
> >
>
> >Â Â Â > > > > > > > > > > commit
> cda2006eded0ed91974e1d9e7f9f288e65812a3e
>
> >
>
> >Â Â Â > > > > > > > > > > Author: Ani Sinha <ani@anisinha.ca>
>
> >
>
> >Â Â Â > > > > > > > > > > Date:Â Â Tue Sep 29 03:22:52 2020 -0400
>
> >
>
> >Â Â Â > > > > > > > > > >
>
> >
>
> >Â Â Â > > > > > > > > > >Â Â Â tests/acpi: update golden master DSDT
> binary
> table
>
> >Â Â Â blobs for q35
>
> >
>
> >Â Â Â > > > > > > > > > >
>
> >
>
> >Â Â Â > > > > > > > > > >
>
> >
>
> >Â Â Â > > > > > > > > > > This is not my patch. It has all sorts of
> changes
> which
>
> >Â Â Â does not
>
> >
>
> >Â Â Â > > > > > > > > > > belong there. Can you please check?
>
> >
>
> >Â Â Â > > > > > > > > >
>
> >
>
> >Â Â Â > > > > > > > > > See https://patchew.org/QEMU/
>
> >Â Â Â 20200929071948.281157-1-mst@redhat.com/
>
> >Â Â Â 20200929071948.281157-46-mst@redhat.com/
>
> >
>
> >Â Â Â > > > > > > > >
>
> >
>
> >Â Â Â > > > > > > > >
>
> >
>
> >Â Â Â > > > > > > > > I had to regenerate the binary, yes. That's par
> for
> the
>
> >Â Â Â course.
>
> >
>
> >Â Â Â > > > > > > > > But it looks like I added disasssembled files.
> Will
> fix up
>
> >Â Â Â and drop,
>
> >
>
> >Â Â Â > > > > > > > > thanks for noticing this.
>
> >
>
> >Â Â Â > > > > > >
>
> >
>
> >Â Â Â > > > > > > OK I pushed out a fixed variant. Pls take a look.
>
> >
>
> >Â Â Â > > > > >
>
> >
>
> >Â Â Â > > > > > OK I am not used to this workflow. How am I supposed
> to get
> it?
>
> >Â Â Â Which tag?
>
> >
>
> >Â Â Â > > > >
>
> >
>
> >Â Â Â > > > > New for_upstream tag - I just sent in a pull request.
>
> >
>
> >Â Â Â > > >
>
> >
>
> >Â Â Â > > > Can you please point me to your tree?
>
> >
>
> >Â Â Â > >
>
> >
>
> >Â Â Â > >
>
> >
>
> >Â Â Â > >Â Â git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/
> for_upstream
>
> >
>
> >Â Â Â >
>
> >
>
> >Â Â Â > I have sent the updated patches based on your pull request
> tag. I
> just
>
> >
>
> >Â Â Â > had to regenrated the blob for
> tests/data/acpi/pc/DSDT.hpbrroot.
>
> >
>
> >Â Â Â >
>
> >
>
> >Â Â Â > make && make check-qtest-x86_64 V=1 passes.
>
> >
>
> >Â Â Â >
>
> >
>
> >Â Â Â > The diff looks good.
>
> >
>
> >Â Â Â >
>
> >
>
> >Â Â Â > Can you please send a pull request with these two patches ASAP?
>
> >
>
> >
>
> >
>
> >
>
> >
>
> >Â Â Â Thanks, I will queue them and merge in the next pull request.
>
> >
>
> >
>
> > I'm willing to get down on my knees begging you to just do one another
> pull
>
> > request for these two patches. Were so close with my entire work merged.
>
> >
>
> > Please let's not wait another week or so.Â
>
>
>
>
>
> OK it's not too much work but ... could you please add justification
>
> about why adding this one unit test is needed so urgently?
>
> That motivation would be quite helpful for the pull request.
>
>
> A patch without unit test doesn't complete the patch work. A unit test makes
> sure that the change would not get broken by other changes that come in later.
> Typically all code changes are accompanied by unit test in the same patch.
> Hence since the main work has already been merged, the unit test should merge
> ASAP so that no breakage can happen in between.
>
> Plus this completes an entire series of work which I've been working for a
> while. I really would love to see it all merged cleanly and fully completed.
>
Absolutely, thanks for the great work!
I am not sure that's a good justification to rushing a pull request
though ... are you waiting to get paid and it hinges on the test, or are
under a deadline, or something like this? It's okay to say so if so.
>
>
>
>
>
>
> >
>
> >
>
> >
>
> >
>
> >
>
> >Â Â Â > >
>
> >
>
> >Â Â Â > >
>
> >
>
> >Â Â Â > >
>
> >
>
> >Â Â Â > > > >
>
> >
>
> >Â Â Â > > > > >
>
> >
>
> >Â Â Â > > > > > >
>
> >
>
> >Â Â Â > > > > > > > I think DSDT.hbridge is wrong. The checksum looks
> weird:
>
> >
>
> >Â Â Â > > > > > > >
>
> >
>
> >Â Â Â > > > > > > >
>
> >
>
> >   > > > > > > > + *   Length      0x00000B89 (2953)
>
> >
>
> >   > > > > > > >  *   Revision     0x01 ****
> 32-bit table (V1),
> no
>
> >Â Â Â 64-bit math support
>
> >
>
> >   > > > > > > > - *   Checksum     0x05
>
> >
>
> >Â Â Â > > > > > >
>
> >
>
> >Â Â Â > > > > > > What is weird about it?
>
> >
>
> >Â Â Â > > > > > >
>
> >
>
> >Â Â Â > > > > > > >
>
> >
>
> >Â Â Â > > > > > > > This file should be introduced just by one patch.
> my
> patch.
>
> >
>
> >Â Â Â > > > > > >
>
> >
>
> >Â Â Â > > > > > > I just re-run rebuild-expected-aml, no changes.
>
> >
>
> >Â Â Â > > > > > >
>
> >
>
> >Â Â Â > > > > > > I have this:
>
> >
>
> >Â Â Â > > > > > > commit 5e3a486211f02d9ecb18939ca21087515ec81883
>
> >
>
> >Â Â Â > > > > > > Author: Ani Sinha <ani@anisinha.ca>
>
> >
>
> >Â Â Â > > > > > > Date:Â Â Fri Sep 18 14:11:05 2020 +0530
>
> >
>
> >Â Â Â > > > > > >
>
> >
>
> >Â Â Â > > > > > >Â Â Â tests/acpi: unit test for
>
> >Â Â Â 'acpi-pci-hotplug-with-bridge-support' bridge flag
>
> >
>
> >Â Â Â > > > > > >
>
> >
>
> >Â Â Â > > > > > >Â Â Â This change adds a new unit test for the
> global flag
>
> >
>
> >Â Â Â > > > > > >Â Â Â 'acpi-pci-hotplug-with-bridge-support' which
> is
> available
>
> >Â Â Â for cold plugged pci
>
> >
>
> >Â Â Â > > > > > >Â Â Â bridges in i440fx. The flag can be used to
> turn off
> ACPI
>
> >Â Â Â based hotplug support
>
> >
>
> >Â Â Â > > > > > >Â Â Â on all pci bridges.
>
> >
>
> >Â Â Â > > > > > >
>
> >
>
> >Â Â Â > > > > > >
>
> >
>
> >Â Â Â > > > > > > Here is the full DSDT header, attached:
>
> >
>
> >Â Â Â > > > > > >
>
> >
>
> >Â Â Â > > > > > > /*
>
> >
>
> >Â Â Â > > > > > >Â * Intel ACPI Component Architecture
>
> >
>
> >Â Â Â > > > > > >Â * AML/ASL+ Disassembler version 20190509 (64-bit
> version)
>
> >
>
> >Â Â Â > > > > > >Â * Copyright (c) 2000 - 2019 Intel Corporation
>
> >
>
> >Â Â Â > > > > > >Â *
>
> >
>
> >Â Â Â > > > > > >Â * Disassembling to symbolic ASL+ operators
>
> >
>
> >Â Â Â > > > > > >Â *
>
> >
>
> >Â Â Â > > > > > >Â * Disassembly of tests/data/acpi/pc/DSDT.hpbridge,
> Tue
> Sep 29
>
> >Â Â Â 06:51:03 2020
>
> >
>
> >Â Â Â > > > > > >Â *
>
> >
>
> >Â Â Â > > > > > >Â * Original Table Header:
>
> >
>
> >   > > > > > > *   Signature    "DSDT"
>
> >
>
> >   > > > > > > *   Length      0x0000139D (5021)
>
> >
>
> >   > > > > > > *   Revision     0x01 **** 32-bit
> table (V1), no
> 64-bit
>
> >Â Â Â math support
>
> >
>
> >   > > > > > > *   Checksum     0x05
>
> >
>
> >Â Â Â > > > > > >Â *Â Â Â OEM IDÂ Â Â Â Â Â "BOCHS "
>
> >
>
> >Â Â Â > > > > > >Â *Â Â Â OEM Table IDÂ Â Â "BXPCDSDT"
>
> >
>
> >   > > > > > > *   OEM Revision   0x00000001 (1)
>
> >
>
> >Â Â Â > > > > > >Â *Â Â Â Compiler IDÂ Â Â "BXPC"
>
> >
>
> >Â Â Â > > > > > >Â *Â Â Â Compiler Version 0x00000001 (1)
>
> >
>
> >Â Â Â > > > > > >Â */
>
> >
>
> >Â Â Â > > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT",
>
> >Â Â Â 0x00000001)
>
> >
>
> >Â Â Â > > > > > >
>
> >
>
> >Â Â Â > > > > > > --
>
> >
>
> >Â Â Â > > > > > > MST
>
> >
>
> >Â Â Â > > > > > >
>
> >
>
> >Â Â Â > > > >
>
> >
>
> >Â Â Â > >
>
> >
>
> >
>
> >
>
> >
>
>
>
>
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, (continued)
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Michael S. Tsirkin, 2020/09/29
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Ani Sinha, 2020/09/29
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Michael S. Tsirkin, 2020/09/29
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Ani Sinha, 2020/09/29
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Michael S. Tsirkin, 2020/09/29
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Ani Sinha, 2020/09/29
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Michael S. Tsirkin, 2020/09/30
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Ani Sinha, 2020/09/30
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Michael S. Tsirkin, 2020/09/30
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Ani Sinha, 2020/09/30
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug,
Michael S. Tsirkin <=
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Ani Sinha, 2020/09/30
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Ani Sinha, 2020/09/30
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Michael S. Tsirkin, 2020/09/30
- Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug, Ani Sinha, 2020/09/30
Re: [PATCH v10 00/13] i440fx/acpi: addition of feature and bug fixes., Philippe Mathieu-Daudé, 2020/09/18