Re: [PATCH 4/4] qemu/bswap: Remove <byteswap.h> dependency

[Richard Henderson]

On 9/23/20 3:30 AM, Philippe Mathieu-Daudé wrote:
> On 9/23/20 12:16 PM, Peter Maydell wrote:
>> I suppose if we wanted to just use the __builtin_bswap*
>> implementation on all hosts (ie drop the special casing
>> of CONFIG_MACHINE_BSWAP_H/FreeBSD/Haiku) we'd need to
>> rename our macros to avoid potential conflicts with the
>> versions in the system headers there in case they were
>> pulled in via some other path ?
> 
> Yes, this is why I couldn't get ride of everything
> 
> After reading Paolo's suggestion to use qatomic*, I
> am tempted to suggest qbswap* but I am still looking
> for better alternatives...

Hum, maybe.  It's pretty ugly.  We could just leave those alone and hope the
system version is decent enough.


r~