[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/4] qemu/bswap: Replace bswapXX() by compiler __builtin_bswap()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 2/4] qemu/bswap: Replace bswapXX() by compiler __builtin_bswap() |
Date: |
Wed, 23 Sep 2020 12:02:18 +0200 |
Use the compiler built-in function to byte swap values,
as the compiler is clever and will fold constants.
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/qemu/bswap.h | 30 ++++--------------------------
1 file changed, 4 insertions(+), 26 deletions(-)
diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
index 8b01c38040c..d1a2f700f2a 100644
--- a/include/qemu/bswap.h
+++ b/include/qemu/bswap.h
@@ -27,32 +27,10 @@ static inline uint64_t bswap64(uint64_t x)
{
return bswap_64(x);
}
-# else
-static inline uint16_t bswap16(uint16_t x)
-{
- return (((x & 0x00ff) << 8) |
- ((x & 0xff00) >> 8));
-}
-
-static inline uint32_t bswap32(uint32_t x)
-{
- return (((x & 0x000000ffU) << 24) |
- ((x & 0x0000ff00U) << 8) |
- ((x & 0x00ff0000U) >> 8) |
- ((x & 0xff000000U) >> 24));
-}
-
-static inline uint64_t bswap64(uint64_t x)
-{
- return (((x & 0x00000000000000ffULL) << 56) |
- ((x & 0x000000000000ff00ULL) << 40) |
- ((x & 0x0000000000ff0000ULL) << 24) |
- ((x & 0x00000000ff000000ULL) << 8) |
- ((x & 0x000000ff00000000ULL) >> 8) |
- ((x & 0x0000ff0000000000ULL) >> 24) |
- ((x & 0x00ff000000000000ULL) >> 40) |
- ((x & 0xff00000000000000ULL) >> 56));
-}
+#else
+# define bswap16(_x) __builtin_bswap16(_x)
+# define bswap32(_x) __builtin_bswap32(_x)
+# define bswap64(_x) __builtin_bswap64(_x)
#endif /* ! CONFIG_MACHINE_BSWAP_H */
static inline void bswap16s(uint16_t *s)
--
2.26.2
- [PATCH 0/4] qemu/bswap: Use compiler __builtin_bswap(), Philippe Mathieu-Daudé, 2020/09/23
- [PATCH 1/4] qemu/bswap: Remove unused qemu_bswap_len(), Philippe Mathieu-Daudé, 2020/09/23
- [PATCH 2/4] qemu/bswap: Replace bswapXX() by compiler __builtin_bswap(),
Philippe Mathieu-Daudé <=
- [PATCH 3/4] qemu/bswap: Replace bswapXXs() by compiler __builtin_bswap(), Philippe Mathieu-Daudé, 2020/09/23
- [PATCH 4/4] qemu/bswap: Remove <byteswap.h> dependency, Philippe Mathieu-Daudé, 2020/09/23
- Re: [PATCH 4/4] qemu/bswap: Remove <byteswap.h> dependency, Peter Maydell, 2020/09/23
- Re: [PATCH 4/4] qemu/bswap: Remove <byteswap.h> dependency, Philippe Mathieu-Daudé, 2020/09/23
- Re: [PATCH 4/4] qemu/bswap: Remove <byteswap.h> dependency, Richard Henderson, 2020/09/24
- Re: [PATCH 4/4] qemu/bswap: Remove <byteswap.h> dependency, Peter Maydell, 2020/09/24
- Re: [PATCH 4/4] qemu/bswap: Remove <byteswap.h> dependency, Philippe Mathieu-Daudé, 2020/09/25
- Re: [PATCH 4/4] qemu/bswap: Remove <byteswap.h> dependency, Richard Henderson, 2020/09/25