[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 5/9] audio: remove unnecessary calls to put_buffer_in
From: |
Gerd Hoffmann |
Subject: |
[PULL 5/9] audio: remove unnecessary calls to put_buffer_in |
Date: |
Wed, 23 Sep 2020 11:09:57 +0200 |
From: Volker RĂ¼melin <vr_qemu@t-online.de>
This patch removes unnecessary calls to the pcm_ops function
put_buffer_in(). No audio backend needs this call if the
returned length of pcm_ops function get_buffer_in() is zero.
For the DirectSound backend this prevents a call to
dsound_unlock_in() without a preceding call to dsound_lock_in().
While Windows doesn't complain it seems wrong anyway.
Signed-off-by: Volker RĂ¼melin <vr_qemu@t-online.de>
Message-id: 20200920171729.15861-5-vr_qemu@t-online.de
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
audio/audio.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index 5c47a036028c..341edc4d0012 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -1261,7 +1261,6 @@ static size_t audio_pcm_hw_run_in(HWVoiceIn *hw, size_t
samples)
assert(size % hw->info.bytes_per_frame == 0);
if (size == 0) {
- hw->pcm_ops->put_buffer_in(hw, buf, size);
break;
}
@@ -1502,7 +1501,6 @@ size_t audio_generic_read(HWVoiceIn *hw, void *buf,
size_t size)
void *src = hw->pcm_ops->get_buffer_in(hw, &src_size);
if (src_size == 0) {
- hw->pcm_ops->put_buffer_in(hw, src, src_size);
break;
}
--
2.27.0
- [PULL 0/9] Audio 20200923 patches, Gerd Hoffmann, 2020/09/23
- [PULL 1/9] audio: handle buf == NULL in put_buffer_out(), Gerd Hoffmann, 2020/09/23
- [PULL 4/9] audio: align audio_generic_read with audio_pcm_hw_run_in, Gerd Hoffmann, 2020/09/23
- [PULL 2/9] audio/audio: fix video playback slowdown with spiceaudio, Gerd Hoffmann, 2020/09/23
- [PULL 9/9] audio: build spiceaudio as module, Gerd Hoffmann, 2020/09/23
- [PULL 6/9] audio: align audio_generic_write with audio_pcm_hw_run_out, Gerd Hoffmann, 2020/09/23
- [PULL 7/9] audio: run downstream playback queue unconditionally, Gerd Hoffmann, 2020/09/23
- [PULL 3/9] audio/spiceaudio: always rate limit playback stream, Gerd Hoffmann, 2020/09/23
- [PULL 5/9] audio: remove unnecessary calls to put_buffer_in,
Gerd Hoffmann <=
- [PULL 8/9] audio: remove qemu_spice_audio_init(), Gerd Hoffmann, 2020/09/23
- Re: [PULL 0/9] Audio 20200923 patches, Peter Maydell, 2020/09/24