[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/9] audio: align audio_generic_read with audio_pcm_hw_run_in
From: |
Gerd Hoffmann |
Subject: |
[PULL 4/9] audio: align audio_generic_read with audio_pcm_hw_run_in |
Date: |
Wed, 23 Sep 2020 11:09:56 +0200 |
From: Volker RĂ¼melin <vr_qemu@t-online.de>
The function audio_generic_read should work exactly like
audio_pcm_hw_run_in. It's a very similar function working
on a different buffer.
Signed-off-by: Volker RĂ¼melin <vr_qemu@t-online.de>
Message-id: 20200920171729.15861-4-vr_qemu@t-online.de
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
audio/audio.c | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index d5891e1928bc..5c47a036028c 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -1495,12 +1495,23 @@ size_t audio_generic_write(HWVoiceOut *hw, void *buf,
size_t size)
size_t audio_generic_read(HWVoiceIn *hw, void *buf, size_t size)
{
- void *src = hw->pcm_ops->get_buffer_in(hw, &size);
+ size_t total = 0;
- memcpy(buf, src, size);
- hw->pcm_ops->put_buffer_in(hw, src, size);
+ while (total < size) {
+ size_t src_size = size - total;
+ void *src = hw->pcm_ops->get_buffer_in(hw, &src_size);
- return size;
+ if (src_size == 0) {
+ hw->pcm_ops->put_buffer_in(hw, src, src_size);
+ break;
+ }
+
+ memcpy((char *)buf + total, src, src_size);
+ hw->pcm_ops->put_buffer_in(hw, src, src_size);
+ total += src_size;
+ }
+
+ return total;
}
static int audio_driver_init(AudioState *s, struct audio_driver *drv,
--
2.27.0
- [PULL 0/9] Audio 20200923 patches, Gerd Hoffmann, 2020/09/23
- [PULL 1/9] audio: handle buf == NULL in put_buffer_out(), Gerd Hoffmann, 2020/09/23
- [PULL 4/9] audio: align audio_generic_read with audio_pcm_hw_run_in,
Gerd Hoffmann <=
- [PULL 2/9] audio/audio: fix video playback slowdown with spiceaudio, Gerd Hoffmann, 2020/09/23
- [PULL 9/9] audio: build spiceaudio as module, Gerd Hoffmann, 2020/09/23
- [PULL 6/9] audio: align audio_generic_write with audio_pcm_hw_run_out, Gerd Hoffmann, 2020/09/23
- [PULL 7/9] audio: run downstream playback queue unconditionally, Gerd Hoffmann, 2020/09/23
- [PULL 3/9] audio/spiceaudio: always rate limit playback stream, Gerd Hoffmann, 2020/09/23
- [PULL 5/9] audio: remove unnecessary calls to put_buffer_in, Gerd Hoffmann, 2020/09/23
- [PULL 8/9] audio: remove qemu_spice_audio_init(), Gerd Hoffmann, 2020/09/23
- Re: [PULL 0/9] Audio 20200923 patches, Peter Maydell, 2020/09/24