[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/8] i8259: Rename PIC to ISA_I8259
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH 4/8] i8259: Rename PIC to ISA_I8259 |
|
Date: |
Fri, 4 Sep 2020 09:48:00 +0100 |
|
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Thu, Sep 03, 2020 at 02:01:24PM -0400, Eduardo Habkost wrote:
> Rename the type checking function to be consistent with the type
> name constant (TYPE_ISA_I8259) and the QOM type name string
> ("isa-i8259").
>
> Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Suggested-by: "Daniel P. Berrangé" <berrange@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: qemu-devel@nongnu.org
> ---
> hw/intc/i8259.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 0/8] qom: Rename macros for consistency (pass 2), Eduardo Habkost, 2020/09/03
- [PATCH 1/8] i8254: Rename TYPE_I8254 to TYPE_ISA_PIT, Eduardo Habkost, 2020/09/03
- [PATCH 2/8] i8254: Rename PIT to ISA_PIT, Eduardo Habkost, 2020/09/03
- [PATCH 3/8] i8259: Rename TYPE_I8259 to TYPE_ISA_I8259, Eduardo Habkost, 2020/09/03
- [PATCH 4/8] i8259: Rename PIC to ISA_I8259, Eduardo Habkost, 2020/09/03
- Re: [PATCH 4/8] i8259: Rename PIC to ISA_I8259,
Daniel P . Berrangé <=
- [PATCH 5/8] i8259: Rename KVM_PIC to KVM_I8259, Eduardo Habkost, 2020/09/03
- [PATCH 6/8] esp-pci: Rename TYPE_AM53C974_DEVICE to TYPE_AM53C974, Eduardo Habkost, 2020/09/03
- [PATCH 7/8] esp-pci: Rename PCI_ESP to AM53C974, Eduardo Habkost, 2020/09/03
- [PATCH 8/8] tusb6010: Rename TUSB to TUSB6010, Eduardo Habkost, 2020/09/03