[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/8] i8254: Rename TYPE_I8254 to TYPE_ISA_PIT
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 1/8] i8254: Rename TYPE_I8254 to TYPE_ISA_PIT |
Date: |
Fri, 4 Sep 2020 09:44:13 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Thu, Sep 03, 2020 at 02:01:21PM -0400, Eduardo Habkost wrote:
> This will make the type name constant consistent with the name of
> the QOM type ("isa-pit").
>
> Suggested-by: "Daniel P. Berrangé" <berrange@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Changes v1 -> v2:
> * v1 subject was: "i8254: Rename TYPE_I8254 to TYPE_PIT"
> * Rename it to TYPE_ISA_PIT instead of TYPE_PIT,
> to be consistent with the existing "isa-pit" type
> name
> ---
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: qemu-devel@nongnu.org
> ---
> include/hw/timer/i8254.h | 4 ++--
> hw/timer/i8254.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 0/8] qom: Rename macros for consistency (pass 2), Eduardo Habkost, 2020/09/03
- [PATCH 1/8] i8254: Rename TYPE_I8254 to TYPE_ISA_PIT, Eduardo Habkost, 2020/09/03
- Re: [PATCH 1/8] i8254: Rename TYPE_I8254 to TYPE_ISA_PIT,
Daniel P . Berrangé <=
- [PATCH 2/8] i8254: Rename PIT to ISA_PIT, Eduardo Habkost, 2020/09/03
- [PATCH 3/8] i8259: Rename TYPE_I8259 to TYPE_ISA_I8259, Eduardo Habkost, 2020/09/03
- [PATCH 4/8] i8259: Rename PIC to ISA_I8259, Eduardo Habkost, 2020/09/03
- [PATCH 5/8] i8259: Rename KVM_PIC to KVM_I8259, Eduardo Habkost, 2020/09/03
- [PATCH 6/8] esp-pci: Rename TYPE_AM53C974_DEVICE to TYPE_AM53C974, Eduardo Habkost, 2020/09/03