Re: [PATCH for-5.1?] target/i386: Save cc_op before loop insns

[Richard Henderson]

On 7/24/20 11:53 AM, Paolo Bonzini wrote:
> Looks good, will queue when I am back---or just send a pull request yourself 
> if
> you prefer.

Ok, will do.  Thanks.


r~

> 
> Paolo
> 
> Il ven 24 lug 2020, 20:35 Richard Henderson <richard.henderson@linaro.org
> <mailto:richard.henderson@linaro.org>> ha scritto:
> 
>     Ping?
> 
>     On 7/20/20 8:40 AM, Richard Henderson wrote:
>     > We forgot to update cc_op before these branch insns,
>     > which lead to losing track of the current eflags.
>     >
>     > Buglink: https://bugs.launchpad.net/qemu/+bug/1888165
>     > Signed-off-by: Richard Henderson <richard.henderson@linaro.org
>     <mailto:richard.henderson@linaro.org>>
>     > ---
>     >  target/i386/translate.c | 1 +
>     >  1 file changed, 1 insertion(+)
>     >
>     > diff --git a/target/i386/translate.c b/target/i386/translate.c
>     > index a1d31f09c1..caea6f5fb1 100644
>     > --- a/target/i386/translate.c
>     > +++ b/target/i386/translate.c
>     > @@ -7148,6 +7148,7 @@ static target_ulong disas_insn(DisasContext *s,
>     CPUState *cpu)
>     >              l1 = gen_new_label();
>     >              l2 = gen_new_label();
>     >              l3 = gen_new_label();
>     > +            gen_update_cc_op(s);
>     >              b &= 3;
>     >              switch(b) {
>     >              case 0: /* loopnz */
>     >
>