[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.1?] target/i386: Save cc_op before loop insns
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH for-5.1?] target/i386: Save cc_op before loop insns |
|
Date: |
Fri, 24 Jul 2020 11:34:57 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
Ping?
On 7/20/20 8:40 AM, Richard Henderson wrote:
> We forgot to update cc_op before these branch insns,
> which lead to losing track of the current eflags.
>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1888165
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/i386/translate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/i386/translate.c b/target/i386/translate.c
> index a1d31f09c1..caea6f5fb1 100644
> --- a/target/i386/translate.c
> +++ b/target/i386/translate.c
> @@ -7148,6 +7148,7 @@ static target_ulong disas_insn(DisasContext *s,
> CPUState *cpu)
> l1 = gen_new_label();
> l2 = gen_new_label();
> l3 = gen_new_label();
> + gen_update_cc_op(s);
> b &= 3;
> switch(b) {
> case 0: /* loopnz */
>