[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/7] pc-bios: s390x: Remove unneeded dasd-ipl.c reset psw mas
From: |
Thomas Huth |
Subject: |
Re: [PATCH 3/7] pc-bios: s390x: Remove unneeded dasd-ipl.c reset psw mask changes |
Date: |
Tue, 21 Jul 2020 09:10:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 20/07/2020 14.16, Janosch Frank wrote:
> On 7/20/20 1:45 PM, Thomas Huth wrote:
>> On 15/07/2020 11.40, Janosch Frank wrote:
>>> jump_to_low_kernel() and the functions that it calls will already or
>>> 64 bit addressing into the reset psw mask when executing
>>> jump_to_IPL_2() after the diag308 subcode 1.
>>
>> But there is also a check in jump_to_low_kernel that could be affected
>> by your change:
>>
>> if (*((uint64_t *)0) & RESET_PSW_MASK) {
>> jump_to_IPL_code((*((uint64_t *)0)) & PSW_MASK_SHORT_ADDR);
>> }
>>
>> ... but I assume that there should not be any kernels out there in the
>> wild which do not have these bits set, so I think your modifications
>> here should be ok.
>
> The mask needs to have the short bit indication set so it needs to be !=
> 0 anyway, no?
That's true. If there were still broken images out there, they should
have stopped working since commit 104130cb7c106378da anyway.
Thomas
- [PATCH 0/7] pc-bios: s390x: Cleanup part 2, Janosch Frank, 2020/07/15
- [PATCH 6/7] pc-bios: s390x: Use PSW constants in start.S, Janosch Frank, 2020/07/15
- [PATCH 7/7] pc-bios: s390x: Setup io and ext new psws only once, Janosch Frank, 2020/07/15
- Re: [PATCH 7/7] pc-bios: s390x: Setup io and ext new psws only once, Janosch Frank, 2020/07/15
- Re: [PATCH 7/7] pc-bios: s390x: Setup io and ext new psws only once, Christian Borntraeger, 2020/07/15
- [PATCH] pc-bios: s390x: Add a comment to the io and external new PSW setup, Janosch Frank, 2020/07/15
- Re: [PATCH] pc-bios: s390x: Add a comment to the io and external new PSW setup, Thomas Huth, 2020/07/21
- Re: [PATCH] pc-bios: s390x: Add a comment to the io and external new PSW setup, Christian Borntraeger, 2020/07/22
- Re: [PATCH] pc-bios: s390x: Add a comment to the io and external new PSW setup, Janosch Frank, 2020/07/22