[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] pc-bios: s390x: Add a comment to the io and external new PSW
From: |
Thomas Huth |
Subject: |
Re: [PATCH] pc-bios: s390x: Add a comment to the io and external new PSW setup |
Date: |
Tue, 21 Jul 2020 09:03:04 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 15/07/2020 16.08, Janosch Frank wrote:
> Normally they don't need to be set up before waiting for an interrupt
> but are set up on boot. The BIOS however might overwrite the lowcore
> (and hence the PSWs) when loading a blob into memory and therefore
> needs to set up those PSWs more often.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> pc-bios/s390-ccw/start.S | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/pc-bios/s390-ccw/start.S b/pc-bios/s390-ccw/start.S
> index 01c4c21b26..b0fcb918cc 100644
> --- a/pc-bios/s390-ccw/start.S
> +++ b/pc-bios/s390-ccw/start.S
> @@ -64,7 +64,10 @@ consume_sclp_int:
> stctg %c0,%c0,0(%r15)
> oi 6(%r15),0x2
> lctlg %c0,%c0,0(%r15)
> - /* prepare external call handler */
> + /*
> + * Prepare external new PSW as it might have been overwritten
> + * by a loaded blob
> + */
> larl %r1, external_new_code
> stg %r1, 0x1b8
> larl %r1, external_new_mask
> @@ -84,7 +87,10 @@ consume_io_int:
> stctg %c6,%c6,0(%r15)
> oi 4(%r15), 0xff
> lctlg %c6,%c6,0(%r15)
> - /* prepare i/o call handler */
> + /*
> + * Prepare i/o new PSW as it might have been overwritten
> + * by a loaded blob
> + */
> larl %r1, io_new_code
> stg %r1, 0x1f8
> larl %r1, io_new_mask
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
- Re: [PATCH 3/7] pc-bios: s390x: Remove unneeded dasd-ipl.c reset psw mask changes, (continued)
[PATCH 6/7] pc-bios: s390x: Use PSW constants in start.S, Janosch Frank, 2020/07/15
[PATCH 7/7] pc-bios: s390x: Setup io and ext new psws only once, Janosch Frank, 2020/07/15
- Re: [PATCH 7/7] pc-bios: s390x: Setup io and ext new psws only once, Janosch Frank, 2020/07/15
- Re: [PATCH 7/7] pc-bios: s390x: Setup io and ext new psws only once, Christian Borntraeger, 2020/07/15
- [PATCH] pc-bios: s390x: Add a comment to the io and external new PSW setup, Janosch Frank, 2020/07/15
- Re: [PATCH] pc-bios: s390x: Add a comment to the io and external new PSW setup,
Thomas Huth <=
- Re: [PATCH] pc-bios: s390x: Add a comment to the io and external new PSW setup, Christian Borntraeger, 2020/07/22
- Re: [PATCH] pc-bios: s390x: Add a comment to the io and external new PSW setup, Janosch Frank, 2020/07/22
- Re: [PATCH] pc-bios: s390x: Add a comment to the io and external new PSW setup, Christian Borntraeger, 2020/07/22
- Re: [PATCH] pc-bios: s390x: Add a comment to the io and external new PSW setup, Janosch Frank, 2020/07/22
[PATCH 5/7] pc-bios: s390x: Replace lowcore offsets with pointers in dasd-ipl.c, Janosch Frank, 2020/07/15
[PATCH 4/7] pc-bios: s390x: Rework data initialization, Janosch Frank, 2020/07/15
[PATCH 2/7] pc-bios: s390x: Cleanup jump to ipl code, Janosch Frank, 2020/07/15