Re: [PULL v2 00/52] Misc patches for QEMU 5.1 soft freeze

[Thomas Huth]

On 10/07/2020 17.47, Daniel P. Berrangé wrote:
> On Fri, Jul 10, 2020 at 04:42:11PM +0100, Peter Maydell wrote:
>> On Fri, 10 Jul 2020 at 16:31, Max Reitz <mreitz@redhat.com> wrote:
>>>
>>> On 10.07.20 17:18, Peter Maydell wrote:
>>>> readarray only arrived sometime in bash 4, and the OSX system
>>>> bash is 3.2.57, so it won't have that builtin.
>>>
>>> It arrived with 4.0, actually, which was released 11 years ago.
>>> I had assumed that would be sufficiently mature.
>>>
>>> So, um, 11 years isn’t sufficiently mature then and I’ll have to work
>>> around not having readarray for macOS?
>>
>> It's the usual Apple-vs-GPL3 issue.
>>
>> I note that the iotests do seem to regularly run into
>> non-portable constructs: Kevin's latest pullreq has
>> just failed due to a use of 'truncate' that doesn't
>> work on the BSDs.
> 
> Since we already depend on homebrew for the build environment, we can
> pull in the newer bash from homebrew, and ignore the ancient version
> from macOS stock install.

I just had the same idea. And then add a simple check for bash 3.x in
tests/check-block.sh so that it skips the iotests if only the old
version is available.

 Thomas