[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 00/32] AVR port
From: |
Peter Maydell |
Subject: |
Re: [PULL 00/32] AVR port |
Date: |
Fri, 10 Jul 2020 16:12:36 +0100 |
On Fri, 10 Jul 2020 at 16:03, Thomas Huth <thuth@redhat.com> wrote:
> Endianess bug ... this should fix it:
>
> diff --git a/target/avr/helper.c b/target/avr/helper.c
> --- a/target/avr/helper.c
> +++ b/target/avr/helper.c
> @@ -337,6 +337,7 @@ void helper_fullwr(CPUAVRState *env, uint32_t data,
> uint32_t addr)
> helper_outb(env, addr - NUMBER_OF_CPU_REGISTERS, data);
> } else {
> /* memory */
> - cpu_physical_memory_write(OFFSET_DATA + addr, &data, 1);
> + uint8_t data8 = data;
> + cpu_physical_memory_write(OFFSET_DATA + addr, &data8, 1);
> }
Or equivalently
address_space_stb(&address_space_memory, data, MEMTXATTRS_UNSPECIFIED, NULL);
(better choices of address space may be available, but this is
the exact-same-behaviour one).
> }
thanks
-- PMM
- [PULL 27/32] tests/boot-serial: Test some Arduino boards (AVR based), (continued)
- [PULL 27/32] tests/boot-serial: Test some Arduino boards (AVR based), Philippe Mathieu-Daudé, 2020/07/07
- [PULL 23/32] hw/misc: avr: Add limited support for power reduction device, Philippe Mathieu-Daudé, 2020/07/07
- [PULL 31/32] target/avr/cpu: Fix $PC displayed address, Philippe Mathieu-Daudé, 2020/07/07
- [PULL 32/32] target/avr/disas: Fix store instructions display order, Philippe Mathieu-Daudé, 2020/07/07
- [PULL 28/32] tests/acceptance: Test the Arduino MEGA2560 board, Philippe Mathieu-Daudé, 2020/07/07
- [PULL 29/32] target/avr: Add section into QEMU documentation, Philippe Mathieu-Daudé, 2020/07/07
- [PULL 25/32] hw/avr: Add some ATmega microcontrollers, Philippe Mathieu-Daudé, 2020/07/07
- [PULL 30/32] target/avr/cpu: Drop tlb_flush() in avr_cpu_reset(), Philippe Mathieu-Daudé, 2020/07/07
- Re: [PULL 00/32] AVR port, Peter Maydell, 2020/07/10
- Re: [PULL 00/32] AVR port, Thomas Huth, 2020/07/10
- Re: [PULL 00/32] AVR port,
Peter Maydell <=
- Re: [PULL 00/32] AVR port, Philippe Mathieu-Daudé, 2020/07/10
- Re: [PULL 00/32] AVR port, Philippe Mathieu-Daudé, 2020/07/10
- Re: [PULL 00/32] AVR port, Thomas Huth, 2020/07/10
- Re: [PULL 00/32] AVR port, Richard Henderson, 2020/07/10
- Re: [PULL 00/32] AVR port, Philippe Mathieu-Daudé, 2020/07/10