Re: [PULL v2 00/52] Misc patches for QEMU 5.1 soft freeze

[Claudio Fontana]

On 7/10/20 2:14 PM, Peter Maydell wrote:
> On Wed, 8 Jul 2020 at 22:32, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> The following changes since commit eb2c66b10efd2b914b56b20ae90655914310c925:
>>
>>   Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2020-07-06' 
>> into staging (2020-07-07 19:47:26 +0100)
>>
>> are available in the Git repository at:
>>
>>   git://github.com/bonzini/qemu.git tags/for-upstream
>>
>> for you to fetch changes up to 392f34e59755f99d69586a63e0f5d80a7ef67f94:
>>
>>   apic: Report current_count via 'info lapic' (2020-07-08 10:01:08 -0400)
> 
> Hi; this still has the OSX failure, I'm afraid:
> 
> /Users/pm215/src/qemu-for-merges/ui/cocoa.m:1478:9: error: implicit
> declaration of function 'cpu_throttle_set' is invalid in C99 [-
> Werror,-Wimplicit-function-declaration]
>         cpu_throttle_set(throttle_pct);
>         ^
> /Users/pm215/src/qemu-for-merges/ui/cocoa.m:1478:9: error: this
> function declaration is not a prototype [-Werror,-Wstrict-prototypes]
> 
> (other builds haven't reported back yet)
> 
> thanks
> -- PMM
> 

Hi Peter,

I got regular green test reports from cirrus-ci for Mac, seems different 
compilation options.

The prototypes for cpu_throttle_ functions are 

in sysemu/cpu-throttle.h

so the fix should be to just

#include "sysemu-cpu_throttle.h"

The fact that we get so wildly different results from CI is concerning to me.

Should I resend you the cpu throttle patch with this change?

Ciao

C