qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v2 1/6] cpus: extract out TCG-specific code to accel/tcg


From: Paolo Bonzini
Subject: Re: [RFC v2 1/6] cpus: extract out TCG-specific code to accel/tcg
Date: Tue, 7 Jul 2020 18:58:56 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0

On 07/07/20 15:58, Claudio Fontana wrote:
> +
> +CpusAccel tcg_cpus = {
> +    .create_vcpu_thread = tcg_start_vcpu_thread,
> +    .kick_vcpu_thread = tcg_kick_vcpu_thread,
> +
> +    .synchronize_post_reset = tcg_cpu_synchronize_noop,
> +    .synchronize_post_init = tcg_cpu_synchronize_noop,
> +    .synchronize_state = tcg_cpu_synchronize_noop,
> +    .synchronize_pre_loadvm = tcg_cpu_synchronize_noop,
> +};

Could this struct reside in AccelClass instead, so that there's no need
to register the operations explicitly?  We could still cache it in a
global variable in accel_init_machine, in order to avoid pointer chasing.

Thanks,

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]